Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependent address error remove #3986

Merged
merged 3 commits into from
Jul 3, 2024
Merged

dependent address error remove #3986

merged 3 commits into from
Jul 3, 2024

Conversation

scaustin34
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • [x} There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/story/show/187869442

A brief description of the changes

Current behavior: unneeded warning alway shows

New behavior: removed warning

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

AppScan CodeSweep Failure

In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD

Add all required notes to this section if the failure is a suspected false positive.

@scaustin34 scaustin34 merged commit 4c3915f into clean-bootstrap-4-upgrade Jul 3, 2024
15 of 16 checks passed
@scaustin34 scaustin34 deleted the 187869442_dep_address_warning_fix branch July 3, 2024 18:48
@bbodine1 bbodine1 mentioned this pull request Jul 5, 2024
Closed
kristinmerbach pushed a commit that referenced this pull request Jul 12, 2024
@scaustin34 @kristinmerbach
dependent address error remove (#3986)
48a50a1 
* remove unecessary error message

* remove uneceaasry modal
ATBull81 pushed a commit that referenced this pull request Jul 19, 2024
@scaustin34 @ATBull81
dependent address error remove (#3986)
95b39ed 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Jul 22, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
5d5bee4 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Jul 26, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
e3606d9 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Jul 30, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
7ba5300 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Jul 31, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
8986277 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 1, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
469f1d8 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 2, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
9de3555 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 3, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
a5c7208 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 6, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
acaff35 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 7, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
f780075 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 9, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
08ae570 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 10, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
90f46ea 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 13, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
4f00b6c 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 14, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
4cc5115 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 15, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
fe3ef0f 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 16, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
ed5fa89 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 19, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
8b32ac9 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 20, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
5ce4e4c 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 20, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
665f125 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 22, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
fca911b 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 23, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
7a86986 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 27, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
c931984 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 28, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
887484b 
* remove unecessary error message

* remove uneceaasry modal
bbodine1 pushed a commit that referenced this pull request Aug 29, 2024
@scaustin34 @bbodine1
dependent address error remove (#3986)
a06391f 
* remove unecessary error message

* remove uneceaasry modal
kristinmerbach pushed a commit that referenced this pull request Sep 4, 2024
@scaustin34 @kristinmerbach
dependent address error remove (#3986)
d4b1ff2 
* remove unecessary error message

* remove uneceaasry modal
kristinmerbach pushed a commit that referenced this pull request Sep 6, 2024
@scaustin34 @kristinmerbach
dependent address error remove (#3986)
ff75442 
* remove unecessary error message

* remove uneceaasry modal
kristinmerbach pushed a commit that referenced this pull request Sep 10, 2024
@scaustin34 @kristinmerbach
dependent address error remove (#3986)
8f5f96f 
* remove unecessary error message

* remove uneceaasry modal
charlienparker pushed a commit that referenced this pull request Sep 13, 2024
@scaustin34 @charlienparker
dependent address error remove (#3986)
e7be99b 
* remove unecessary error message

* remove uneceaasry modal
charlienparker pushed a commit that referenced this pull request Sep 16, 2024
@scaustin34 @charlienparker
dependent address error remove (#3986)
b29a484 
* remove unecessary error message

* remove uneceaasry modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ATBull81 ATBull81 ATBull81 approved these changes

@charlienparker charlienparker charlienparker approved these changes

@kristinmerbach kristinmerbach Awaiting requested review from kristinmerbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scaustin34 @ATBull81 @charlienparker