Support nested color function + Add whiteness & blackness #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parsing issue causing "Missing closing parentheses" even if it looks fine. Also, better error reporting when possible. Should close ianstormtaylor/rework-color-function#4
MoOx
changed the title
This was referenced Jul 23, 2014
Closed
|
bump :) |
|
@ianstormtaylor do you want 2 PRs for that ? |
|
ah awesome, sorry i think i unwatched the repo so didnt get updated until you re-mentioned. looks good to me! |
ianstormtaylor
added a commit
that referenced
this pull request
Aug 11, 2014
Support nested color function + Add whiteness & blackness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing issue causing "Missing closing parentheses" even if it
looks fine.
Also, better error reporting when possible.
Should close ianstormtaylor/rework-color-function#4