Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] parse hwb values #1

Closed
kristoferjoseph opened this issue Apr 9, 2014 · 4 comments
Closed

[FEATURE] parse hwb values #1

kristoferjoseph opened this issue Apr 9, 2014 · 4 comments

Comments

@kristoferjoseph
Copy link

I started to add the contrast adjuster as specified in the CSS Color Module 4 spec and realized that the parser doesn't accept hwb colors.

My reasoning for using hwb for this is it allows you to manipulate contrast while leaving the hue at the correct angle for later adjustments without requiring further conversions.

Can you give any guidance as to how you would want that added?

There is a conversion function specified in the spec here hwbToRgb that could be added to the parser if you want. Was thinking I could publish a module with just the hwb converters in it for anyone to use.

Thoughts?

@ianstormtaylor
Copy link
Owner

hey! that sounds awesome. i think the best way might be to get support for hwb included in color? since that's the lib i was using underneath. if not that, then ideally we could just parse from hwb at the start into something that color recognizes and then use it still, to keep a single code path

@kristoferjoseph
Copy link
Author

Funny you should mention that. I have a branch in my fork of color that does just that. I'll make a PR and see if she can find it in her heart to merge it. If not can we talk more about adding it to the parser? Thanks! 💌

@MoOx
Copy link
Collaborator

MoOx commented Jul 17, 2014

Will be handled by my incoming PR (ref)

@kristoferjoseph
Copy link
Author

\0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants