Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknow value #5

Closed
MoOx opened this issue Jul 17, 2014 · 2 comments · Fixed by #6
Closed

Ignore unknow value #5

MoOx opened this issue Jul 17, 2014 · 2 comments · Fixed by #6

Comments

@MoOx
Copy link
Collaborator

MoOx commented Jul 17, 2014

I've spotted a bug on myth with rebeccapurple.
It's added to late (after rework-color-function) so doing stuff like color(rebeccapurple alpha(80%)) just don't work.
So I just move the plugin before rework-color-function but got an issue for my test should be able to disable rebeccapurple node support & it's related how this plugin don't handle unknown color.
I found that it's related to color lib that doesn't warn when it fail to parse a color so I made a PR to fix that.

Qix-/color#26

When this get merged we should be able to detect that & probably just do nothing when we don't recognize a value.
Maybe we can just warn the user ? Any idea how to make a friendly warning ?

@MoOx
Copy link
Collaborator Author

MoOx commented Jul 17, 2014

(Note the issue is: it give rgb(0,0,0) for unknow color)

@MoOx
Copy link
Collaborator Author

MoOx commented Jul 23, 2014

PR has been merged & exceptions are now thrown starting 0.7(.1). So we will need to handle that right after the merged of the #4
I'll prepare something tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant