feat: connection less presentation #1285

mineme0110 · 2024-08-13T15:09:01Z

Description:

This PR introduces two new endpoints in the present-proof flow:

An endpoint to create an Out-of-Band (OOB) invitation with a Request Presentation attached in a DIDComm message. This also updates the PresentationRecord with a new state, InvitationGenerated, and stores the invitation within the PresentationRecord.(https://input-output.atlassian.net/browse/ATL-6624)
An endpoint to accept the OOB invitation, parse the OOB message, and update the protocol state to RequestReceived.
(https://input-output.atlassian.net/browse/ATL-6630)

Checklist:

My PR follows the contribution guidelines of this project
My PR is free of third-party dependencies that don't comply with the Allowlist
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked the PR title to follow the conventional commit specification

github-actions · 2024-08-13T15:25:07Z

Integration Test Results

20 files ±0 20 suites ±0 2s ⏱️ ±0s
45 tests ±0 45 ✅ ±0 0 💤 ±0 0 ❌ ±0
71 runs ±0 71 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 9fff6f8. ± Comparison against base commit 120fa57.

♻️ This comment has been updated with latest results.

github-actions · 2024-08-14T10:57:05Z

Unit Test Results

96 files ±0 96 suites ±0 23m 57s ⏱️ + 1m 54s
826 tests ±0 818 ✅ ±0 8 💤 ±0 0 ❌ ±0
833 runs ±0 825 ✅ ±0 8 💤 ±0 0 ❌ ±0

Results for commit 9fff6f8. ± Comparison against base commit 120fa57.

♻️ This comment has been updated with latest results.

yshyn-iohk · 2024-08-14T13:17:33Z

.../server/src/main/scala/org/hyperledger/identus/agent/server/jobs/PresentBackgroundJobs.scala

@@ -96,13 +96,17 @@ object PresentBackgroundJobs extends BackgroundJobsHelper {
    for {
      _ <- ZIO.logDebug(s"Running action with records => $record")
      _ <- record match {
-        case PresentationRecord(id, _, _, _, _, _, _, _, ProposalPending, _, _, _, _, _, _, _, _, _, _, _, _) =>
+        case PresentationRecord(_, _, _, _, _, _, _, _, InvitationGenerated, _, _, _, _, _, _, _, _, _, _, _, _, _) =>


I'm dreaming about somebody refactoring this _ _ _ _ _ _ _ _ _ _ _ code :)

same
I'm have a hard time trying to merge those changes

yshyn-iohk · 2024-08-14T13:19:48Z

...scala/org/hyperledger/identus/presentproof/controller/http/OOBRequestPresentationInput.scala

+    object anoncredPresentationRequest
+        extends Annotation[Option[AnoncredPresentationRequestV1]](
+          description = "Anoncred Presentation Request",
+          example = Some(


@mineme0110, could you ensure that this example is correctly serialized and encoded in the OAS?

yshyn-iohk · 2024-08-14T13:20:24Z

...ore/src/main/scala/org/hyperledger/identus/pollux/core/service/PresentationServiceImpl.scala

@@ -1189,6 +1222,56 @@ private class PresentationServiceImpl(
      record <- getRecord(id)
    } yield record

+  // override def createOOBPresentationRecord(


should it be deleted?

Signed-off-by: mineme0110 <[email protected]>

# [1.39.0-beta.1](cloud-agent-v1.38.0...cloud-agent-v1.39.0-beta.1) (2024-08-20) ### Bug Fixes * [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0)) * add beta branch to trigger the release ([33771b5](33771b5)) * add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f)) * bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613)) * changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639)) * escape "" in the dumpLicenses command ([aed67c6](aed67c6)) * improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf)) * migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc)) * misc spelling ([#1288](#1288)) ([88efa9c](88efa9c)) * rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef)) ### Features * connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1)) * Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87)) * Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64)) * postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe)) [skip ci] Signed-off-by: Hyperledger Bot <[email protected]>

# [1.39.0](cloud-agent-v1.38.0...cloud-agent-v1.39.0) (2024-09-11) ### Bug Fixes * [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0)) * add License to the POM files [#1099](#1099) ([#1310](#1310)) ([5a7b950](5a7b950)) * add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f)) * bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613)) * changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639)) * cleanup and minor refactoring to remove duplicates ([#1309](#1309)) ([238492b](238492b)) * delete subject id from presentation record ([#1314](#1314)) ([b73b806](b73b806)) * GET Requested present proof by Holder ([#1316](#1316)) ([3b3da2c](3b3da2c)) * improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf)) * migrate to quill for generic secret storage ([#1299](#1299)) ([e077cdd](e077cdd)) * migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc)) * misc spelling ([#1288](#1288)) ([88efa9c](88efa9c)) * operation id repeated error ([#1306](#1306)) ([8e39d0b](8e39d0b)) * remove `prism-agent` path from the apisixroute.yaml ([#1330](#1330)) ([82b9d1d](82b9d1d)) * remove deprecation warnings and optimize tests performance ([#1315](#1315)) ([7558245](7558245)) * Remove type DID ([#1327](#1327)) ([1ed2a14](1ed2a14)) * rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef)) * replace problematic dependency license from Apollo ([#1312](#1312)) ([11ee9df](11ee9df)) * the oob encode invitation ([#1313](#1313)) ([f2313f2](f2313f2)) ### Features * API Supports ValidFrom And ValidTo ([#1298](#1298)) ([b19f514](b19f514)) * API Supports ValidFrom And ValidTo (PART 2) ([#1302](#1302)) ([b0c58f3](b0c58f3)) * API Supports ValidFrom And ValidTo Test ([#1305](#1305)) ([3a7984b](3a7984b)) * connection less issuance ([#1301](#1301)) ([594f7c9](594f7c9)) * connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1)) * connection less presentation expiration time ([#1294](#1294)) ([6024c97](6024c97)) * Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87)) * Fix Object causing StatusList to fail ([#1322](#1322)) ([fb32d6e](fb32d6e)) * Handle Error Notify webhooks ATL-6934 ([#1279](#1279)) ([7c31a9d](7c31a9d)) * integrate json-path in presentation definition ([#1311](#1311)) ([9ef6b09](9ef6b09)) * Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64)) * postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe)) * presentation-exchange model and json schema refactoring ([#1304](#1304)) ([75b2736](75b2736)) * URL or Object as Issuer ([#1321](#1321)) ([0c53bba](0c53bba)) [skip ci] Signed-off-by: Hyperledger Bot <[email protected]>

mineme0110 requested a review from a team as a code owner August 13, 2024 15:09

github-actions bot added pollux build mercury cloud-agent labels Aug 13, 2024

petevielhaber approved these changes Aug 13, 2024

View reviewed changes

mineme0110 force-pushed the feat/connection-less-presentation branch from b0df3f0 to 8dc3c7f Compare August 14, 2024 10:39

yshyn-iohk reviewed Aug 14, 2024

View reviewed changes

yshyn-iohk approved these changes Aug 14, 2024

View reviewed changes

mineme0110 changed the title ~~WIP feat/connection less presentation~~ feat:connection less presentation Aug 14, 2024

mineme0110 changed the title ~~feat:connection less presentation~~ feat: connection less presentation Aug 14, 2024

mineme0110 added 7 commits August 15, 2024 09:59

WIP feat: connection less presentation

621d559

Signed-off-by: mineme0110 <[email protected]>

WIP feat: connection less presentation

f20f87b

Signed-off-by: mineme0110 <[email protected]>

scalafmt

0299b40

Signed-off-by: mineme0110 <[email protected]>

Update the endpoints for connectionless

10c9666

Signed-off-by: mineme0110 <[email protected]>

fix test

357fb3c

Signed-off-by: mineme0110 <[email protected]>

code cleanup

bc12efd

Signed-off-by: mineme0110 <[email protected]>

code cleanup

9fff6f8

Signed-off-by: mineme0110 <[email protected]>

mineme0110 force-pushed the feat/connection-less-presentation branch from edd9d53 to 9fff6f8 Compare August 15, 2024 08:59

mineme0110 merged commit c5846d1 into main Aug 15, 2024
12 checks passed

mineme0110 deleted the feat/connection-less-presentation branch August 15, 2024 09:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: connection less presentation #1285

feat: connection less presentation #1285

mineme0110 commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

yshyn-iohk Aug 14, 2024

FabioPinheiro Aug 20, 2024

yshyn-iohk Aug 14, 2024

yshyn-iohk Aug 14, 2024

feat: connection less presentation #1285

feat: connection less presentation #1285

Conversation

mineme0110 commented Aug 13, 2024 • edited Loading

Description:

Checklist:

github-actions bot commented Aug 13, 2024 • edited Loading

Integration Test Results

github-actions bot commented Aug 14, 2024 • edited Loading

Unit Test Results

yshyn-iohk Aug 14, 2024

Choose a reason for hiding this comment

FabioPinheiro Aug 20, 2024

Choose a reason for hiding this comment

yshyn-iohk Aug 14, 2024

Choose a reason for hiding this comment

yshyn-iohk Aug 14, 2024

Choose a reason for hiding this comment

mineme0110 commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading