fix: bitString base64 encoding for revocation status list #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shota Jolbordi <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
petevielhaber
approved these changes
Jul 26, 2024
yshyn-iohk
approved these changes
Jul 29, 2024
yshyn-iohk
pushed a commit
that referenced
this pull request
Aug 20, 2024
# [1.39.0-beta.1](cloud-agent-v1.38.0...cloud-agent-v1.39.0-beta.1) (2024-08-20) ### Bug Fixes * [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0)) * add beta branch to trigger the release ([33771b5](33771b5)) * add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f)) * bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613)) * changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639)) * escape "" in the dumpLicenses command ([aed67c6](aed67c6)) * improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf)) * migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc)) * misc spelling ([#1288](#1288)) ([88efa9c](88efa9c)) * rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef)) ### Features * connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1)) * Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87)) * Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64)) * postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe)) [skip ci] Signed-off-by: Hyperledger Bot <[email protected]>
hyperledger-bot
added a commit
that referenced
this pull request
Sep 11, 2024
# [1.39.0](cloud-agent-v1.38.0...cloud-agent-v1.39.0) (2024-09-11) ### Bug Fixes * [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0)) * add License to the POM files [#1099](#1099) ([#1310](#1310)) ([5a7b950](5a7b950)) * add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f)) * bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613)) * changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639)) * cleanup and minor refactoring to remove duplicates ([#1309](#1309)) ([238492b](238492b)) * delete subject id from presentation record ([#1314](#1314)) ([b73b806](b73b806)) * GET Requested present proof by Holder ([#1316](#1316)) ([3b3da2c](3b3da2c)) * improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf)) * migrate to quill for generic secret storage ([#1299](#1299)) ([e077cdd](e077cdd)) * migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc)) * misc spelling ([#1288](#1288)) ([88efa9c](88efa9c)) * operation id repeated error ([#1306](#1306)) ([8e39d0b](8e39d0b)) * remove `prism-agent` path from the apisixroute.yaml ([#1330](#1330)) ([82b9d1d](82b9d1d)) * remove deprecation warnings and optimize tests performance ([#1315](#1315)) ([7558245](7558245)) * Remove type DID ([#1327](#1327)) ([1ed2a14](1ed2a14)) * rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef)) * replace problematic dependency license from Apollo ([#1312](#1312)) ([11ee9df](11ee9df)) * the oob encode invitation ([#1313](#1313)) ([f2313f2](f2313f2)) ### Features * API Supports ValidFrom And ValidTo ([#1298](#1298)) ([b19f514](b19f514)) * API Supports ValidFrom And ValidTo (PART 2) ([#1302](#1302)) ([b0c58f3](b0c58f3)) * API Supports ValidFrom And ValidTo Test ([#1305](#1305)) ([3a7984b](3a7984b)) * connection less issuance ([#1301](#1301)) ([594f7c9](594f7c9)) * connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1)) * connection less presentation expiration time ([#1294](#1294)) ([6024c97](6024c97)) * Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87)) * Fix Object causing StatusList to fail ([#1322](#1322)) ([fb32d6e](fb32d6e)) * Handle Error Notify webhooks ATL-6934 ([#1279](#1279)) ([7c31a9d](7c31a9d)) * integrate json-path in presentation definition ([#1311](#1311)) ([9ef6b09](9ef6b09)) * Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64)) * postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe)) * presentation-exchange model and json schema refactoring ([#1304](#1304)) ([75b2736](75b2736)) * URL or Object as Issuer ([#1321](#1321)) ([0c53bba](0c53bba)) [skip ci] Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix the encoding of bitSring for the revocation status list to follow the spec, currently, it is encoding bit string, by first converting it to bytes, and then to base64, but byte conversion changes the order of bites from right to left, which is a bug.
Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist: