Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GITHUB_TOKEN should be optional #1259

Closed
FabioPinheiro opened this issue Jul 11, 2024 · 2 comments
Closed

GITHUB_TOKEN should be optional #1259

FabioPinheiro opened this issue Jul 11, 2024 · 2 comments

Comments

@FabioPinheiro
Copy link
Contributor

FabioPinheiro commented Jul 11, 2024 •
edited
Loading

Is this a regression?

Yes

Description

This is not a bug, but it is a regression.

GITHUB_TOKEN environment variable (required for SBT plugins and access to the GitHub packages)

Yes the GITHUB_TOKEN is required by a SBT plugins used in the CI. But this plugin is not necessary to run it locally. We also are not depending on any package from GitHub that need the GITHUB to be set up ATM.

I configure the build to make this plugin to only load when running on the CI. But someone deleted that configuration after a few weeks.
In my opinion is very inconvenient to setting up that variable as blank just for the SBT to load.

Please provide the exception or error you saw

[error] (shared / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (sharedCrypto / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (prismNodeClient / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (castorCore / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (models / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolRevocationNotification / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolInvitation / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolRouting / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolMercuryMailbox / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (eventNotification / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolTrustPing / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (resolver / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (polluxVcJWT / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolReportProblem / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolCoordinateMediation / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (sharedTest / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolPresentProof / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolIssueCredential / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (vc / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolLogin / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolConnection / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (agent / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (agentDidcommx / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (agentWalletAPI / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (polluxSDJWT / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (polluxAnoncreds / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (polluxCore / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (polluxDoobie / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (protocolDidExchange / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (connectCore / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (connectDoobie / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (cloudAgentServer / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] (polluxAnoncredsTest / credentials) unable to locate a valid GitHub token from Environment(GITHUB_TOKEN)
[error] Total time: 0 s, completed Jul 11, 2024, 11:06:00 AM
@yshyn-iohk
Copy link
Member

@FabioPinheiro, could you point to the PR? We can return the code back.

FabioPinheiro added a commit that referenced this issue Jul 31, 2024
@FabioPinheiro
fix: #1259 make GITHUB_TOKEN optional
d72e753 
Signed-off-by: FabioPinheiro <[email protected]>
@FabioPinheiro
Copy link
Contributor Author

Here is the fix again.
I need to test the build for release

@github-project-automation github-project-automation bot moved this to Status: Completed in Project Roadmap Aug 2, 2024
yshyn-iohk pushed a commit that referenced this issue Aug 20, 2024
@hyperledger-bot
chore(release): cut the Identus Cloud agent 1.39.0-beta.1 release
b11893e 
# [1.39.0-beta.1](cloud-agent-v1.38.0...cloud-agent-v1.39.0-beta.1) (2024-08-20)

### Bug Fixes

* [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0))
* add beta branch to trigger the release ([33771b5](33771b5))
* add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f))
* bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613))
* changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639))
* escape "" in the dumpLicenses command ([aed67c6](aed67c6))
* improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf))
* migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc))
* misc spelling ([#1288](#1288)) ([88efa9c](88efa9c))
* rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef))

### Features

* connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1))
* Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87))
* Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64))
* postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe))

 [skip ci]

Signed-off-by: Hyperledger Bot <[email protected]>
hyperledger-bot added a commit that referenced this issue Sep 11, 2024
@hyperledger-bot
chore(release): cut the Identus Cloud agent 1.39.0 release
797dad4 
# [1.39.0](cloud-agent-v1.38.0...cloud-agent-v1.39.0) (2024-09-11)

### Bug Fixes

* [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0))
* add License to the POM files [#1099](#1099) ([#1310](#1310)) ([5a7b950](5a7b950))
* add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f))
* bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613))
* changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639))
* cleanup and minor refactoring to remove duplicates ([#1309](#1309)) ([238492b](238492b))
* delete subject id from presentation record ([#1314](#1314)) ([b73b806](b73b806))
* GET Requested present proof by Holder ([#1316](#1316)) ([3b3da2c](3b3da2c))
* improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf))
* migrate to quill for generic secret storage ([#1299](#1299)) ([e077cdd](e077cdd))
* migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc))
* misc spelling ([#1288](#1288)) ([88efa9c](88efa9c))
* operation id repeated error ([#1306](#1306)) ([8e39d0b](8e39d0b))
* remove `prism-agent` path from the apisixroute.yaml ([#1330](#1330)) ([82b9d1d](82b9d1d))
* remove deprecation warnings and optimize tests performance ([#1315](#1315)) ([7558245](7558245))
* Remove type DID ([#1327](#1327)) ([1ed2a14](1ed2a14))
* rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef))
* replace problematic dependency license from Apollo ([#1312](#1312)) ([11ee9df](11ee9df))
* the oob encode invitation ([#1313](#1313)) ([f2313f2](f2313f2))

### Features

* API Supports ValidFrom And ValidTo ([#1298](#1298)) ([b19f514](b19f514))
* API Supports ValidFrom And ValidTo (PART 2) ([#1302](#1302)) ([b0c58f3](b0c58f3))
* API Supports ValidFrom And ValidTo Test ([#1305](#1305)) ([3a7984b](3a7984b))
* connection less issuance ([#1301](#1301)) ([594f7c9](594f7c9))
* connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1))
* connection less presentation expiration time ([#1294](#1294)) ([6024c97](6024c97))
* Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87))
* Fix Object causing StatusList to fail ([#1322](#1322)) ([fb32d6e](fb32d6e))
* Handle Error Notify webhooks ATL-6934 ([#1279](#1279)) ([7c31a9d](7c31a9d))
* integrate json-path in presentation definition ([#1311](#1311)) ([9ef6b09](9ef6b09))
* Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64))
* postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe))
* presentation-exchange model and json schema refactoring ([#1304](#1304)) ([75b2736](75b2736))
* URL or Object as Issuer ([#1321](#1321)) ([0c53bba](0c53bba))

 [skip ci]

Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FabioPinheiro @yshyn-iohk