Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecation warnings and optimize tests performance #1315

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

patlo-iog
Copy link
Contributor

@patlo-iog patlo-iog commented Aug 30, 2024

Description:

  • fix deprecation warnings
  • improve unit test performance - reuse keycloak container and setup / teardown at realm level
    3-4 minutes shaved off from unit test 😱

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Pat Losoponkul <[email protected]>

fix: vault deprecation warnings

Signed-off-by: Pat Losoponkul <[email protected]>

fix: test compile

Signed-off-by: Pat Losoponkul <[email protected]>

test: reuse keycloak container and setup / teardown realm instead

fix: keycloak auth spec shared container

Signed-off-by: Pat Losoponkul <[email protected]>

chore: remove debugging code

Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog added the autoupdate Merge the main branch into a feature branch label Aug 30, 2024
@patlo-iog patlo-iog marked this pull request as ready for review August 30, 2024 12:30
@patlo-iog patlo-iog requested a review from a team as a code owner August 30, 2024 12:30
@patlo-iog
Copy link
Contributor Author

🚀 Merge success

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Unit Test Results

 98 files  ±0   98 suites  ±0   19m 32s ⏱️ -41s
837 tests ±0  829 ✅ ±0  8 💤 ±0  0 ❌ ±0 
844 runs  ±0  836 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit ad03eac. ± Comparison against base commit b73b806.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
71 runs  ±0  71 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ad03eac. ± Comparison against base commit b73b806.

@patlo-iog patlo-iog changed the title fix: remove deprecation warnings and optimize tests perfomance fix: remove deprecation warnings and optimize tests performance Aug 30, 2024
@patlo-iog patlo-iog enabled auto-merge (squash) August 30, 2024 14:43
@patlo-iog patlo-iog merged commit 7558245 into main Aug 30, 2024
16 checks passed
@patlo-iog patlo-iog deleted the warnings-test-optim branch August 30, 2024 14:58
hyperledger-bot added a commit that referenced this pull request Sep 11, 2024
# [1.39.0](cloud-agent-v1.38.0...cloud-agent-v1.39.0) (2024-09-11)

### Bug Fixes

* [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0))
* add License to the POM files [#1099](#1099) ([#1310](#1310)) ([5a7b950](5a7b950))
* add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f))
* bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613))
* changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639))
* cleanup and minor refactoring to remove duplicates ([#1309](#1309)) ([238492b](238492b))
* delete subject id from presentation record ([#1314](#1314)) ([b73b806](b73b806))
* GET Requested present proof by Holder ([#1316](#1316)) ([3b3da2c](3b3da2c))
* improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf))
* migrate to quill for generic secret storage ([#1299](#1299)) ([e077cdd](e077cdd))
* migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc))
* misc spelling ([#1288](#1288)) ([88efa9c](88efa9c))
* operation id repeated error ([#1306](#1306)) ([8e39d0b](8e39d0b))
* remove `prism-agent` path from the apisixroute.yaml ([#1330](#1330)) ([82b9d1d](82b9d1d))
* remove deprecation warnings and optimize tests performance ([#1315](#1315)) ([7558245](7558245))
* Remove type DID ([#1327](#1327)) ([1ed2a14](1ed2a14))
* rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef))
* replace problematic dependency license from Apollo ([#1312](#1312)) ([11ee9df](11ee9df))
* the oob encode invitation ([#1313](#1313)) ([f2313f2](f2313f2))

### Features

* API Supports ValidFrom And ValidTo ([#1298](#1298)) ([b19f514](b19f514))
* API Supports ValidFrom And ValidTo (PART 2) ([#1302](#1302)) ([b0c58f3](b0c58f3))
* API Supports ValidFrom And ValidTo Test ([#1305](#1305)) ([3a7984b](3a7984b))
* connection less issuance ([#1301](#1301)) ([594f7c9](594f7c9))
* connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1))
* connection less presentation expiration time ([#1294](#1294)) ([6024c97](6024c97))
* Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87))
* Fix Object causing StatusList to fail ([#1322](#1322)) ([fb32d6e](fb32d6e))
* Handle Error Notify webhooks ATL-6934 ([#1279](#1279)) ([7c31a9d](7c31a9d))
* integrate json-path in presentation definition ([#1311](#1311)) ([9ef6b09](9ef6b09))
* Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64))
* postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe))
* presentation-exchange model and json schema refactoring ([#1304](#1304)) ([75b2736](75b2736))
* URL or Object as Issuer ([#1321](#1321)) ([0c53bba](0c53bba))

 [skip ci]

Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants