Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: presentation-exchange model and json schema refactoring #1304

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

patlo-iog
Copy link
Contributor

@patlo-iog patlo-iog commented Aug 28, 2024

Description:

  • refactor json-schema and other json code to shared-json module
  • add polluxPreX module for presentation-exchange objects and logic
  • move PresentationDefinition from poluxCore to polluxPreX and add validator + tests

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Pat Losoponkul added 2 commits August 28, 2024 16:48
Signed-off-by: Pat Losoponkul <[email protected]>
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Integration Test Results

20 files  20 suites   2s ⏱️
45 tests 45 ✅ 0 💤 0 ❌
71 runs  71 ✅ 0 💤 0 ❌

Results for commit a2a788b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Unit Test Results

 97 files   97 suites   22m 13s ⏱️
829 tests 821 ✅ 8 💤 0 ❌
836 runs  828 ✅ 8 💤 0 ❌

Results for commit a2a788b.

♻️ This comment has been updated with latest results.

Pat Losoponkul added 2 commits August 28, 2024 17:39
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
import zio.*
import zio.json.ast.Json as ZioJson

// TODO: define proper type
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this later. The change is now is getting big and prefer to merge.

Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog marked this pull request as ready for review August 28, 2024 11:54
@patlo-iog patlo-iog requested a review from a team as a code owner August 28, 2024 11:54
@patlo-iog patlo-iog changed the title feat: presentation-exchange model and json schema refactoring [WIP] feat: presentation-exchange model and json schema refactoring Aug 28, 2024
@patlo-iog patlo-iog added the autoupdate Merge the main branch into a feature branch label Aug 28, 2024
Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks clean

@patlo-iog patlo-iog removed the autoupdate Merge the main branch into a feature branch label Aug 28, 2024
@github-actions github-actions bot added the ci label Aug 29, 2024
@patlo-iog patlo-iog added the autoupdate Merge the main branch into a feature branch label Aug 29, 2024
@patlo-iog
Copy link
Contributor Author

🚀 Merge success!

@patlo-iog patlo-iog enabled auto-merge (squash) August 29, 2024 08:43
@patlo-iog patlo-iog merged commit 75b2736 into main Aug 29, 2024
12 checks passed
@patlo-iog patlo-iog deleted the feat/prex-1 branch August 29, 2024 08:58
hyperledger-bot added a commit that referenced this pull request Sep 11, 2024
# [1.39.0](cloud-agent-v1.38.0...cloud-agent-v1.39.0) (2024-09-11)

### Bug Fixes

* [#1259](#1259) make GITHUB_TOKEN optional ([#1275](#1275)) ([1c9cbd0](1c9cbd0))
* add License to the POM files [#1099](#1099) ([#1310](#1310)) ([5a7b950](5a7b950))
* add reportProcessingFailure back in PresentationRepository ([#1232](#1232)) ([d22745f](d22745f))
* bitString base64 encoding for revocation status list ([#1273](#1273)) ([45e0613](45e0613))
* changed IO to UIO as as underline repository doesn't throw error ([#1271](#1271)) ([2aba639](2aba639))
* cleanup and minor refactoring to remove duplicates ([#1309](#1309)) ([238492b](238492b))
* delete subject id from presentation record ([#1314](#1314)) ([b73b806](b73b806))
* GET Requested present proof by Holder ([#1316](#1316)) ([3b3da2c](3b3da2c))
* improve k8s keycloak bootstrapping script ([#1278](#1278)) ([cfc4ccf](cfc4ccf))
* migrate to quill for generic secret storage ([#1299](#1299)) ([e077cdd](e077cdd))
* migrate wallet nonsecret storage to quill ([#1290](#1290)) ([525b3bc](525b3bc))
* misc spelling ([#1288](#1288)) ([88efa9c](88efa9c))
* operation id repeated error ([#1306](#1306)) ([8e39d0b](8e39d0b))
* remove `prism-agent` path from the apisixroute.yaml ([#1330](#1330)) ([82b9d1d](82b9d1d))
* remove deprecation warnings and optimize tests performance ([#1315](#1315)) ([7558245](7558245))
* Remove type DID ([#1327](#1327)) ([1ed2a14](1ed2a14))
* rename folder from atala to identus ([#1270](#1270)) ([12660ef](12660ef))
* replace problematic dependency license from Apollo ([#1312](#1312)) ([11ee9df](11ee9df))
* the oob encode invitation ([#1313](#1313)) ([f2313f2](f2313f2))

### Features

* API Supports ValidFrom And ValidTo ([#1298](#1298)) ([b19f514](b19f514))
* API Supports ValidFrom And ValidTo (PART 2) ([#1302](#1302)) ([b0c58f3](b0c58f3))
* API Supports ValidFrom And ValidTo Test ([#1305](#1305)) ([3a7984b](3a7984b))
* connection less issuance ([#1301](#1301)) ([594f7c9](594f7c9))
* connection less presentation ([#1285](#1285)) ([c5846d1](c5846d1))
* connection less presentation expiration time ([#1294](#1294)) ([6024c97](6024c97))
* Expose Stored Error ([#1276](#1276)) ([758fe87](758fe87))
* Fix Object causing StatusList to fail ([#1322](#1322)) ([fb32d6e](fb32d6e))
* Handle Error Notify webhooks ATL-6934 ([#1279](#1279)) ([7c31a9d](7c31a9d))
* integrate json-path in presentation definition ([#1311](#1311)) ([9ef6b09](9ef6b09))
* Move ADRs to the identus-docs repo ([#1284](#1284)) ([4d5ca64](4d5ca64))
* postgres metrics ([#1274](#1274)) ([cf3ccbe](cf3ccbe))
* presentation-exchange model and json schema refactoring ([#1304](#1304)) ([75b2736](75b2736))
* URL or Object as Issuer ([#1321](#1321)) ([0c53bba](0c53bba))

 [skip ci]

Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants