-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to Tokio 0.3 #2317
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
whoopsie! Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
3 tasks
seanmonstar
reviewed
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the benchmarks are still unhappy, they're guarded by the nightly
cargo feature.
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
seanmonstar
reviewed
Nov 5, 2020
5 tasks
Merged
Finished in #2319 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates Hyper's Tokio dependency to v0.3.x. This continues
the work started by @Urhengulas in PR #2309, updating additional parts
of the codebase and fixing some bugs introduced in that branch.
There are a few important notes:
h2
is currently a Git dependency, so this will block releasing a newHyper version until a new
h2
is published.Tokio 0.3 doesn't currently have vectored IO APIs, so Hyper has
(hopefully temporarily) lost its vectored IO support
AsyncRead::poll_read_buf
andAsyncWrite::poll_write_buf
are beingmoved to
tokio-util
. Currently, they're not available, so we fallback to slicing and advancing
Bytes
andBytesMut
buffersourselves. When support lands upstream, we should change back.
Ideally, Tokio's new
TcpSocket
type should gain support for more ofthe socket options hyper needs to set. If this happens, we should be
able to remove some messy code involving
AsRawFd
/FromRawFd
andsocket2
.This also bumps Hyper's minimum supported Rust version to 1.45.2,
which is Tokio's minimum supported version. Tokio 0.3 doesn't build
on 1.39.0
Closes #2309
Signed-off-by: Eliza Weisman [email protected]
Co-authored-by: Urhengulas [email protected]