-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tokio from 0.2.11 to 0.3 #2309
Conversation
// TODO: There should be a way to do following two lines cleaner... | ||
buf.put_slice(prefix.to_vec().as_slice()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix it
// TODO: There should be a way to do following two lines cleaner... | |
buf.put_slice(prefix.to_vec().as_slice()); | |
buf.put_slice(&prefix[..copy_len]); |
Thanks for this! I had also started a branch just yesterday doing this, which was useful to find all the things that aren't easily fixable in hyper, and started trying to put them back into Tokio. The biggest one is vectored writes, but there's a few smaller things too. I'll list them in the original issue. |
Sounds like a good plan 😁 |
This PR shall update tokio to version
0.3
.Changes
AsyncRead
,AsyncWrite
implementationsdelay_for
->sleep
,Delay
->Sleep
Fixes #2302
There are still quite some errors left to resolve, so I am happy to get some input there 😃