-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to tokio 0.3 and bytes 0.6 #115
Conversation
Hmm, this is the first PR from a fork since the repo switched to GitHub Actions: (it's trying to log into Docker Hub)
It shouldn't be able to push a new master image to the Hub, but communication between workflow jobs does rely on pushing a branch image. |
I'll run the CI build by hand and merge if it passes. If there's anything unexpected on GitHub Actions on master we can follow up with another fix. |
Agreed, let's upgrade the rest and handle hyper separately once it arrives. |
A couple of other compiler errors relating to the changed signature of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sure, appreciated of course! |
Changes
This PR updates all dependencies over
tokio v0.3
andbytes v0.6
Hyper 0.14
The full update would currently be failing since hyper hasn't updated their API to
tokio v0.3
. I believe it is better not to modifyhyper-websocket-lite
in this PR, this should be handled when changes have been merged in hyper.closes #109 #113 #106