Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to tokio 0.3 and bytes 0.6 #115

Merged
merged 5 commits into from
Nov 4, 2020
Merged

update to tokio 0.3 and bytes 0.6 #115

merged 5 commits into from
Nov 4, 2020

Conversation

hyyking
Copy link
Contributor

@hyyking hyyking commented Nov 3, 2020

Changes

This PR updates all dependencies over tokio v0.3 and bytes v0.6

Hyper 0.14

The full update would currently be failing since hyper hasn't updated their API to tokio v0.3. I believe it is better not to modify hyper-websocket-lite in this PR, this should be handled when changes have been merged in hyper.

closes #109 #113 #106

@hyyking hyyking mentioned this pull request Nov 3, 2020
4 tasks
@1tgr
Copy link
Owner

1tgr commented Nov 3, 2020

Hmm, this is the first PR from a fork since the repo switched to GitHub Actions: (it's trying to log into Docker Hub)

Secrets are not passed to workflows that are triggered by a pull request from a fork. Learn more.

It shouldn't be able to push a new master image to the Hub, but communication between workflow jobs does rely on pushing a branch image.

@1tgr
Copy link
Owner

1tgr commented Nov 3, 2020

I'll run the CI build by hand and merge if it passes. If there's anything unexpected on GitHub Actions on master we can follow up with another fix.

@1tgr
Copy link
Owner

1tgr commented Nov 3, 2020

I believe it is better not to modify hyper-websocket-lite in this PR

Agreed, let's upgrade the rest and handle hyper separately once it arrives.

websocket-lite/Cargo.toml Outdated Show resolved Hide resolved
@1tgr
Copy link
Owner

1tgr commented Nov 3, 2020

A couple of other compiler errors relating to the changed signature of poll_read, and the rename of time::delay_for to sleep. Can you cargo check --all-targets and cargo test?

Copy link
Owner

@1tgr 1tgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@1tgr 1tgr merged commit 5b984e2 into 1tgr:master Nov 4, 2020
@1tgr
Copy link
Owner

1tgr commented Nov 4, 2020

@hyyking the build on master looks good. You want me to publish v0.4 to crates.io after #117 is done?

@hyyking
Copy link
Contributor Author

hyyking commented Nov 4, 2020

@hyyking the build on master looks good. You want me to publish v0.4 to crates.io after #117 is done?

I'm in no hurry just wanted to help :)

@1tgr
Copy link
Owner

1tgr commented Nov 4, 2020

Sure, appreciated of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants