First attempt at linter #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2023
Merged
|
I don't know if the only reason to vendor |
gsnedders
commented
Apr 3, 2023
gsnedders
force-pushed
the
linter
branch
2 times, most recently
from
12e7141 to
0d5c740
Compare
Pretty sure it was avoiding external deps. |
|
FWIW: if nobody reviews this and nobody objects, I'm just going to land this in a week so we avoid regressing these things yet again. |
Ms2ger
approved these changes
Apr 6, 2023
lint_lib/lint.py
Outdated
Comment on lines
249
to
255
| if not parsed: | ||
| return |
There was a problem hiding this comment.
If this does something, it should do it in a less cryptic way
There was a problem hiding this comment.
@Ms2ger PTAL at the comments that are there now
This checks that we have the right headers, in the right order, and checks for both duplicate headers and duplicate tests.
gsnedders
commented
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably needs work. And might not work. And should probably have some Travis script first. (i.e., don't merge it)Probably good enough.