Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate tests #159

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Remove duplicate tests #159

merged 1 commit into from
Apr 6, 2023

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Mar 31, 2023

As identified in web-platform-tests/wpt#39305.

@annevk annevk mentioned this pull request Mar 31, 2023
Closed
@gsnedders
Copy link
Member

#83 implemented a linter back in 2016 which would have caught that, but despite many pings nobody has reviewed that in seven years :(

@annevk
Copy link
Contributor Author

annevk commented Mar 31, 2023

Perhaps folks were waiting for you to finish it? Hard to say. If you make it run on CI and it catches these I'm happy to approve it, but I don't have power so...

@annevk
Copy link
Contributor Author

annevk commented Apr 4, 2023

@Ms2ger @gsnedders can I please have a review?

Ms2ger
Ms2ger approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not intending to verify that these are indeed duplicates. Unless someone wants to require that, I'll merge tomorrow.

@annevk
Copy link
Contributor Author

annevk commented Apr 5, 2023

In case someone wants to verify, this output linked from OP might be useful:

Previous HEAD position was 9b4a29c Test </p> and </br> in SVG (#135)
HEAD is now at 1314b09 Correct another <template> test
adoption01
adoption02
blocks
comments01
doctype01
domjs-unsafe
entities01
entities02
foreign-fragment
WARNING: id 74a8a40517c6fe110f0c71af7efb56d459ea8227 seen multiple times in file foreign-fragment this time for test (svg desc, <figure></figure>) before for test ('svg desc', '<figure></figure>'), skipping
html5test-com
inbody01
isindex
main-element
math
menuitem-element
namespace-sensitivity
noscript01
pending-spec-changes-plain-text-unsafe
pending-spec-changes
plain-text-unsafe
ruby
scriptdata01
WARNING: id e04bd4c273176c0638e98dce1cbdcfc6438ec7eb seen multiple times in file scriptdata01 this time for test (None, FOO<script>'<!-->'</script>BAR) before for test (None, "FOO<script>'<!-->'</script>BAR"), skipping
search-element
svg
tables01
template
WARNING: id b4ab56fd9e9cebf479d14adfa523c06d16483a5e seen multiple times in file template this time for test (None, <body><template><template><tr></tr></template><td></td></template>) before for test (None, '<body><template><template><tr></tr></template><td></td></template>'), skipping
WARNING: id d958f7d44faf772d1fb60f1a8f186f837ca735d9 seen multiple times in file template this time for test (None, <body></body><template>) before for test (None, '<body></body><template>'), skipping
tests1
WARNING: id 18b58d1de184b6866963c902ff8451dd3522f540 seen multiple times in file tests1 this time for test (None, <b><table><td><i></table>) before for test (None, '<b><table><td><i></table>'), skipping
WARNING: id daa9d8440e2bc4d560536b52123b01e52aa81692 seen multiple times in file tests1 this time for test (None, <p><hr></p>) before for test (None, '<p><hr></p>'), skipping
tests10
tests11
tests12
tests14
tests15
tests16
tests17
tests18
tests19
WARNING: id 8d45a57b7093df38c88dccb1f3fba6a62c810445 seen multiple times in file tests19 this time for test (None, <!doctype html><select><option></optgroup>) before for test (None, '<!doctype html><select><option></optgroup>'), skipping
WARNING: id 9e4d91f02184de1b1e5d927144bb06d3bc78bb09 seen multiple times in file tests19 this time for test (None, <!doctype html><table><i>a<b>b<div>c<a>d</i>e</b>f) before for test (None, '<!doctype html><table><i>a<b>b<div>c<a>d</i>e</b>f'), skipping
tests2
tests20
WARNING: id aa2a707a627408758a0ee845896ef088d6136013 seen multiple times in file tests20 this time for test (None, <!doctype html><address><button></address>a) before for test (None, '<!doctype html><address><button></address>a'), skipping
tests21
WARNING: id 7cdfc1d2d87a4f9ebd754d18dc7b55f73f5ba58b seen multiple times in file tests21 this time for test (None, <svg><![CDATA[foo) before for test (None, '<svg><![CDATA[foo'), skipping
WARNING: id 30b6ff244d2cd3716c1ad482e30ff294dcfed2b7 seen multiple times in file tests21 this time for test (None, <svg><![CDATA[]] >]]>) before for test (None, '<svg><![CDATA[]] >]]>'), skipping
tests22
tests23
tests24
tests25
tests26
tests3
tests4
tests5
tests6
tests7
tests8
tests9
tests_innerHTML_1
WARNING: id b55e32e22980fe99bab895005a0a757a2fcb1a2b seen multiple times in file tests_innerHTML_1 this time for test (table, <a>) before for test ('table', '<a>'), skipping
WARNING: id f8770f97671a805b37277db7e42536b40c0804cb seen multiple times in file tests_innerHTML_1 this time for test (tbody, <a><td>) before for test ('tbody', '<a><td>'), skipping
WARNING: id f8770f97671a805b37277db7e42536b40c0804cb seen multiple times in file tests_innerHTML_1 this time for test (tbody, <a><td>) before for test ('tbody', '<a><td>'), skipping
WARNING: id dc0e2582ff83e60c0eb549dc3387562d3482e364 seen multiple times in file tests_innerHTML_1 this time for test (tr, <td><table></table><td>) before for test ('tr', '<td><table></table><td>'), skipping
tricky01
webkit01
webkit02
scripted_adoption01
scripted_ark
scripted_webkit01

@gsnedders
Copy link
Member

https://github.com/html5lib/html5lib-tests/actions/runs/4628759515/jobs/8188229486 has got the linter into a working state which also detects these with line numbers, which makes reviewing this easier:

Duplicate item in tree-construction/tests19.dat at line 390 previously seen on line 377
Duplicate item in tree-construction/tests21.dat at line 55 previously seen on line 40
Duplicate item in tree-construction/tests21.dat at line 107 previously seen on line 95
Duplicate item in tree-construction/template.dat at line 870 previously seen on line 516
Duplicate item in tree-construction/scriptdata01.dat at line 175 previously seen on line 162
Duplicate item in tree-construction/tests20.dat at line 536 previously seen on line 523
Duplicate item in tree-construction/tests1.dat at line 1436 previously seen on line 184
Duplicate item in tree-construction/tests1.dat at line 1550 previously seen on line 342
Duplicate item in tree-construction/foreign-fragment.dat at line 481 previously seen on line 445
Duplicate item in tree-construction/tests_innerHTML_1.dat at line 113 previously seen on line 103
Duplicate item in tree-construction/tests_innerHTML_1.dat at line 505 previously seen on line 493
Duplicate item in tree-construction/tests_innerHTML_1.dat at line 517 previously seen on line 493
Duplicate item in tree-construction/tests_innerHTML_1.dat at line 651 previously seen on line 641

@gsnedders gsnedders merged commit 4e82e3d into html5lib:master Apr 6, 2023
@annevk annevk deleted the annevk/template-test branch April 6, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders gsnedders approved these changes

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @gsnedders @Ms2ger