Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html5lib tests (for <isindex>) #2887

Closed
zcorpan opened this issue Apr 22, 2016 · 7 comments
Closed

Update html5lib tests (for <isindex>) #2887

zcorpan opened this issue Apr 22, 2016 · 7 comments
Assignees
Labels

Comments

@zcorpan
Copy link
Member

zcorpan commented Apr 22, 2016

I wanted to update html5lib tests (for html5lib/html5lib-tests#74) and tried to follow the instructions in html/tools/update_html5lib_tests.py and expected at least isindex.dat to have changed but it seems it did not...

git status
On branch htmlpreelement
Your branch is up-to-date with 'origin/htmlpreelement'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   syntax/parsing/html5lib_entities01.html
    modified:   syntax/parsing/html5lib_entities02.html
    modified:   syntax/parsing/html5lib_template.html
    modified:   syntax/parsing/html5lib_tests11.html
    modified:   syntax/parsing/html5lib_tests7.html
    modified:   syntax/parsing/html5lib_webkit01.html
    modified:   syntax/parsing/html5lib_webkit02.html
    modified:   ../resources (new commits)
    modified:   ../tools (new commits)

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    syntax/parsing/html5lib_innerHTML_foreign-fragment.html
    syntax/parsing/html5lib_innerHTML_math.html
    syntax/parsing/html5lib_innerHTML_webkit02.html
    syntax/parsing/html5lib_namespace-sensitivity.html
    syntax/parsing/html5lib_ruby.html
    tools/venv/

cc @jgraham

@zcorpan
Copy link
Member Author

zcorpan commented Apr 28, 2016

@gsnedders can you help?

@gsnedders
Copy link
Member

No, all @jgraham's stuff. (And I'm going on holiday as soon as this delayed flight gets here…)

@foolip
Copy link
Member

foolip commented Oct 13, 2018

Is this issue still relevant? Have we not synced with html5lib in 2+ years?

@zcorpan
Copy link
Member Author

zcorpan commented Oct 13, 2018

I'm afraid so :-/

@foolip
Copy link
Member

foolip commented Oct 13, 2018

Alright, so as part of an upcoming documentation drive we should probably document what all of the third-party does are and how they are updated. Ideally we should have auto-updates from source like for interfaces/ now.

@gsnedders
Copy link
Member

This would be easier to do if we had something to parse the tests in html5lib-tests. Say, like, as part of a linter html5lib/html5lib-tests#83 (PR opened over two years ago!).

@zcorpan
Copy link
Member Author

zcorpan commented Mar 2, 2021

I guess this issue is fixed because html/tools/build.sh hardcodes the html5lib-python commit d49afd3, at which point html5lib-python was using commit 71eebd5 of html5lib-tests which is newer than the isindex change from 2016.

I've created a new issue though because updating parser tests is ... not as easy as it could be: #27868

@zcorpan zcorpan closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants