[OpenGL&Vulkan][Freeze] Saru Getchu PipoSaruRacer (UCJS10032)

[nassau-tk]

What happens?

[Issue No.1]
Graphic(Text?) drawing issue.
Some Text become to very small. (Only first letter)
This issue happen only OpenGL.
Vulkan is drawing correctly.
See attached Screenshots & Dumpfile.

[Issue No.2]
IF you start NewGame then play intro movie.
And game freeze when finish the movie.
You can play the game when if You skip the movie.

Like a... #11060
But,This game is not shutdown.
Just, Freeze.

What should happen?

Drawing graphic correctly.(OpenGL)
Don't crash after the intro movie.

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

PPSSPP Ver. : 1.9.3-577
OS: Android 9.0
DeviceName: SONY SO-02K / Xperia XZ1 Compact (Japan)
CPU: Snapdragon835 (Octa-core)
GPU: Adreno 540
Resolution: 720×1280
RAM: 4GB
ROM:32GB
ExternalStrage: microSDXC 512GB

Dump file here!!
UCJS10032_0001.zip

[OpenGL ==> Vulakn]

[hrydgard]

This feels like it might be related to #12498 . Some wacky viewport invalidation issue maybe?

[nassau-tk]

I feel similar it.

[unknownbrackets]

Excitingly, despite likely being a flushing issue, this does reproduce in the GE dump. The red character is at 21/34.

The problem is that ApplyDrawState is updating shader uniforms, but we only check for that when getting the vshader (before ApplyDrawState.) It only affects GLES, though.

-[Unknown]

[nassau-tk]

@hrydgard
@unknownbrackets
If I provided with useful information of improvement, I'm happy.

[unknownbrackets]

Yep, the detail and dump were very useful indeed.

Unfortunately, I'm not sure about the crash. There are other games that crash when you do or don't skip the video, and I suspect it's a timing issue.

-[Unknown]

[nassau-tk]

Good!
The issue of strange text was solved!!

And, some movie issue is happend many games.
I hope you beat them future!

[sum2012]

v1.9.3-731-gf82e7a4e7-windows-amd64 media log:
https://gist.githubusercontent.com/sum2012/ac1a6122c313b2acdcb04e3f4b36eb6f/raw/22df1be6362517615981df442e6fee37cc2c147f/gistfile1.txt
The game did not call ScempegDelete so that the game hang,

[sum2012]

JPCSPTrace log:
https://gist.github.com/sum2012/a944dcc12bd10fa945945410540f4eb8

Change UNIMPL sceMpegAvcDecodeStopYCbCr
Memory::Write_U32(0, statusAddr); to Memory::Write_U32(1, statusAddr);
No help

[sum2012]

I might want to do again jpcsptrace with more mpeg function to more understand in future

[sum2012]

update ppsspp log to v1.10.3-1375-g52c6169a5
https://gist.github.com/sum2012/52e616ba085f81b91fc887bf2c0b488c/raw/8f7907ac64e9b0544da0eac954df493847be249e/gistfile1.txt

[sum2012]

@nassau-tk I cannot reproduce freeze in this build.
Please check again.Thanks
https://drive.google.com/file/d/1YamV2gBdOSZWHFSrFxda2HmdCa87FcBM/view?usp=sharing

[nassau-tk]

@sum2012

I got log by your customized PPSSPP files.
https://gist.github.com/nassau-tk/e5c51b988d70cf24e04dfcc6f4f4df77

And, I got a movie of Issue point.
Please see below. (My Google Drive.)
https://drive.google.com/file/d/1imb6XBSldLz8xhKv03GSJzxkHdjwDEiW/view?usp=sharing

This issue is not appear "Invalid Memory Access(Blue Screen)".
Just freeze.

[sum2012]

Please see my video,I cannot reproduce anymore
https://youtu.be/PjTVhsmf8U4

[nassau-tk]

What!?
Why!?

I tested on other PC too.
PPSSPP: sum2012 custom
OpenGL
OS: Windows10(64-bit)
CPU: Intel i7-4770K
GPU: NVIDIA GeForce GTX750Ti
RAM:16GB

But, Result is same.(Freeze)

Um.... I don't have any idea.

[sum2012]

Let @hrydgard merge that change,then we test again

[nassau-tk]

@sum2012

Oh!! Sorry!!
I misstake the extract target folder.
So,I couldn't check right on your custom PPSSPP.

And, I re-tested the it.

"Result"
Saru Getchu PipoSaruRacer (UCJS10032) #12768 Freeze issue is solved!!

ppsspp-v1.10.3-1375m1-g52c6169a5-windows-amd64
ppsspp-v1.10.3-1383m-windows-amd64
Both OK!

[sum2012]

@nassau-tk
My 's mpeg warm up patch have merged.Can you test again ?

[nassau-tk]

@sum2012

Yes, I tested on Windows(64-bit).
Result : Not happen the freeze.

And, I tested on Xperia Z1 Compact (Android 9)
Result : Not happen the freeze.

[sum2012]

Good news :)
Closing

[sum2012]

My warm up staff now only for firmware >= 6
Reopening this.

[sum2012]

Hope find correct fix in v1.12

[sum2012]

The game's firmware is 2.81

[sum2012]

JPCSPTrace log: (I play 2 times video to get scempegfinish logging)
https://gist.github.com/sum2012/aa23043a93538ff6bed7520776c51fd7

Real psp sceMpegGetAvcAu return ERROR_MPEG_NO_DATA near at the end of video.
sceMpegGetAtracAu return 0
edit:No warmup in begining

[nassau-tk]

@sum2012

Is this solved???

[sum2012]

@nassau-tk Yes,it is solved

[sum2012]

Fix by my pull request #16106 :)

[nassau-tk]

Awesome work!!