GLES: Update shader uniforms after apply state #12813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may set shaderblend, projmatrix, or depthrange dirty in ApplyDrawState(). These need to update shader uniforms to apply correctly, but we were checking beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may set shaderblend, projmatrix, or depthrange dirty in ApplyDrawState().
These need to update shader uniforms to apply correctly, but we were checking early when applying the vertex shader. There's no benefit to doing it there vs at the fragment shader, and the fragment shader is after ApplyDrawState().
Other backends already check the uniform dirty flags this late.
Fixes the OpenGL issue in #12768, but likely not the freeze. Might fix some depth range issues?
-[Unknown]