Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long-term goal: Remove "Disable slower effects" checkbox, and "Simulate Block Transfers" #11610

Closed
hrydgard opened this issue Nov 29, 2018 · 15 comments
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented Nov 29, 2018

This checkbox breaks so many games and creates many unnecessary bug reports. My goal is to look into all cases that really are very slow, and fix them to work at reasonable performance.

First success here is the virtual readbacks , #11531 , that improved performance of Digimon Adventure (it's still a fairly demanding game for some devices, but at least the massive performance-killing readbacks are gone).

I'm interested in other cases where we end up doing unnecessarily costly operations that this checkbox avoids.

Of course, very weak GPUs might still get stressed from the actual GPU part of the effects so we might not be able to completely remove it, but we should be able to move it into the more obscure options eventually.

Cases:
#11531 Digimon Adventure
#11573 Call of Duty
#11092 3rd Birthday
Burnout Legends sun (should be fixable with the #11531 method with some work)
Tactics Ogre?
Test Drive (#11531 can be used, though needs more fixes)

Related, "Simulate block transfers" has similar problems and should also be removed.

@hrydgard hrydgard added this to the Future milestone Nov 29, 2018
@hrydgard
Copy link
Owner Author

One alternative might be to simply force the checkbox to off for games that require these effects.

#11573 would be a candidate.

@ghost
Copy link

ghost commented Nov 29, 2018

#11092 should also be a candidate?

@hrydgard
Copy link
Owner Author

Yeah, that should definitely be listed here.

@hrydgard hrydgard changed the title Long-term goal: Remove "Disable slower effects" checkbox Long-term goal: Remove "Disable slower effects" checkbox, and "Simulate Block Transfers" Feb 8, 2019
@marosis
Copy link

marosis commented Apr 5, 2019

Posting #11953

@Leopard20
Copy link
Contributor

@hrydgard Burnout Dominator is also affected by "Simulate Block Trans." (disabling it makes the game 2 times faster)

@ghost
Copy link

ghost commented Apr 7, 2019

Burnout Dominator and Burnout Legend benefits from Simulate Block Transfer Effects fixing small square in the sun

Just add the game ID to [BlockTransferAllowCreateFB] compat.ini I just tried both Dominator and Legend game are faster even Simulate Block Transfer Effects is enable I just need to set the rendering resolution to X1 as my phone is low specs 😅

@nassau-tk
Copy link
Contributor

I'm tunr off "Simulate Block Transfers" these game on Android device.
*Windows PC is not need them. Because, I think thatPC has enough CPU&GPU Power.

OS:Android 9.0
DeviceName:SONY SO-02K / Xperia XZ1 Compact(Japan)
CPU:Snapdragon835(Octa-core)
GPU:Adreno 540
Resolution:720×1280
RAM:4GB
ROM:32GB
ExternalStrage:microSDXC 512GB

[Simulate Block Transfers Off==>Can getting enough FPS.]
ARMORED CORE FORMULA FRONT(ULJS00003)
ARMORED CORE FORMULA FRONT International (ULJS19001)
These games get enough FPS and not happen graphic glitched on Android device.

[Getting enough FPS.But happen glitched.]
Tactics Ogre - Unmei no Wa (ULJM05753) will get ennough FPS.
But, It's not drawing some graphics correctly.

[Tactics Ogre-Simulate Block Transfers On/Graphic OK/Goes down FPS]
ULJM05753_BlockTrans_On

[Tactics Ogre-Simulate Block Transfers Off/Graphic Bad/Enough FPS]
ULJM05753_BlockTrans_Off

GachiTora-Abarenbou kyoushi in HighSchool- (NPJH50409) too.
[GachiTora Block Transfers On/Graphic OK/Goes down FPS]
NPJH50409_BlockTrans_On

[GachiTora Block Transfers Off/Graphic Bad/enough FPS]
NPJH50409_BlockTrans_Off

For reference!!

@IrfanH495
Copy link

is 3rd birthday included?
Simulate Block Transfers Effects ON
Screenshot_20221006-212424_PPSSPP
Simulate Block Transfers Effects OFF
Screenshot_20221006-212412_PPSSPP

@hrydgard
Copy link
Owner Author

hrydgard commented Oct 6, 2022

3rd Birthday doesn't need any readbacks as far as I know, so the block transfer option won't affect it anymore (it now only controls readbacks, which are the most expensive operation).

Checking it off from the list.

@ghost
Copy link

ghost commented Oct 7, 2022

Brave Story also benefit from disable slower effects.

ON
Screenshot_2022-10-07-23-46-07-40

OFF
Screenshot_2022-10-07-23-46-18-70

ppsspp v1.13.2

@hrydgard
Copy link
Owner Author

hrydgard commented Oct 7, 2022

Right, @unknownbrackets looked into that game long ago. I had hoped that the new CLUT-from-framebuffer code would take care of that, wonder why it's not.

Are the colors correct in the upper or lower image?

@ghost
Copy link

ghost commented Oct 7, 2022

Are the colors correct in the upper or lower image?

I can't tell what is correct on those screenshots.

I aslo discover that there's an issue in the recently build using OpenGL backend.

OPENGL
Screenshot_2022-10-08-00-26-33-62

VULKAN
Screenshot_2022-10-08-00-26-17-24

Software
Screenshot_2022-10-08-00-26-58-12

@ghost
Copy link

ghost commented Oct 7, 2022

I also notice that during battle scene in Brave Story OpenGL is much better compare to Vulkan.

@hrydgard
Copy link
Owner Author

hrydgard commented Oct 7, 2022

Thanks. We should separate out the Brave Story problems in a separate issue..

@hrydgard hrydgard modified the milestones: Future, v1.14.0 Dec 10, 2022
@hrydgard
Copy link
Owner Author

These checkboxes have been refactored into a single speedhack, "Skip GPU readbacks". Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants