Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] [OpenGL] If "Disable slower effects is unchecked" The 3rd Birthday is very slow #11092

Closed
ghost opened this issue May 28, 2018 · 15 comments

Comments

@ghost
Copy link

ghost commented May 28, 2018

No description provided.

@ghost
Copy link
Author

ghost commented May 28, 2018

screenshot_2018-05-28-23-27-25
And also when I overdrive there's a grapics bugs in The 3rd Birthday (Disable Slower Effects is On)
Im using now the latest ppsspp version 1.6
Phone Specs:
Android 5.1
Mali-450
OpenGL

@unknownbrackets
Copy link
Collaborator

The checkbox can be considered to be "Use graphical bugs for speed". It's expected that there will be graphics bugs when you check the setting.

Which git build was last fast and which was the first one that became slower, when slower effects are allowed (setting unchecked)?

-[Unknown]

@ghost
Copy link
Author

ghost commented May 29, 2018

ppsspp 1.6.1
screenshot_2018-05-29-14-46-55

@ghost
Copy link
Author

ghost commented Jun 1, 2018

In ppsspp-v1.5.4-931-g9c059a7b6 the game running 20+fps in default settings but in ppsspp-v1.5.4-933-g386c9d4fc the game running only 15+FPS in default settings

@ghost
Copy link
Author

ghost commented Jun 1, 2018

This is just a minor issue enable "Disable Slower Effects" speed up the game with a little graphical issue 😃

@unknownbrackets
Copy link
Collaborator

So that's #10956. Maybe there's a way to detect that it's not needed to to combine depals here, but it makes sense unfortunately that fixing #10951 would make it slower.

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Jun 1, 2018

As mentioned in #10956 post processing the display lists like we do with Sonic Rivals on Vulkan is probably the only way to fix this properly, which takes some effort.. and we can currently only do it for Vulkan and OpenGL, though I guess PC:s with DX can probably just brute force through it.

@hrydgard hrydgard added this to the v1.7.0 milestone Jun 1, 2018
@Leopard20
Copy link
Contributor

Leopard20 commented Jun 6, 2018

@hrydgard I also notice slow-downs in other games as well. They are very small to notice on powerful devices though (S7 equivalents and up)

@unknownbrackets
Copy link
Collaborator

For the purpose of recombining, it'd be nice to have some better meta information on the draws - ideally, the clut params / palette hash, source framebuf, and area (maybe this can be read from the verts.) That might allow combining automatically in a general case.

At least for 3rd Birthday, that ought to allow combining. In render-to-self cases, I don't know if it can be automatic without detecting the destination pixel area. It's relatively uncommon, though...

-[Unknown]

@ghost
Copy link
Author

ghost commented Aug 15, 2018

Sad to say 3rd birthday still lag when disable slower effects is OFF :(

@hrydgard hrydgard modified the milestones: v1.7.0, v1.8.0 Sep 16, 2018
@ghost ghost changed the title When Disable Slower Effects is off The 3rd Birthday & Brave: New Traveler become very slow If "Dsable slower effects is unchecked" The 3rd Birthday is very slow Dec 5, 2018
@hrydgard hrydgard changed the title If "Dsable slower effects is unchecked" The 3rd Birthday is very slow If "Disable slower effects is unchecked" The 3rd Birthday is very slow Feb 6, 2019
@hrydgard
Copy link
Owner

Doing something clever here is too much work, it'll unfortunately have to be like this in 1.8.0.

@hrydgard hrydgard modified the milestones: v1.8.0, v1.9.0 Feb 23, 2019
@ghost
Copy link
Author

ghost commented Mar 23, 2019

UPDATE

Using ppsspp v1.8.0 graphics glitches is rarely happens if I enable the "Disable Slower Effects"

@ghost ghost changed the title If "Disable slower effects is unchecked" The 3rd Birthday is very slow [Android] [OpenGL] If "Disable slower effects is unchecked" The 3rd Birthday is very slow Jun 29, 2019
@hrydgard hrydgard modified the milestones: v1.9.0, v1.10.0 Aug 26, 2019
@ghost ghost mentioned this issue Mar 3, 2020
@hrydgard hrydgard modified the milestones: v1.10.0, Future Mar 9, 2020
@ghost ghost mentioned this issue Mar 24, 2020
@ghost
Copy link
Author

ghost commented Mar 24, 2020

Disable Slower Effects in the latest build cannot help speedup this games anymore so I will close this and for the meantime I will use skip buffered rendering for this games
Hoping someday this 2 games will improve performance in buffered rendering :)
The 3rd Birthday Skip Buffered Rendering
Screenshot_20200324-105000
Brave Story Skip Buffered Rendering
Screenshot_20200324-105034

@ghost ghost closed this as completed Mar 24, 2020
@ghost ghost reopened this Apr 2, 2020
@ghost
Copy link
Author

ghost commented Apr 2, 2020

Reopened hoping for OpenGL shader depal can help this issue see #10908 (comment)

@ghost
Copy link
Author

ghost commented Apr 15, 2020

Closing the game is work fine so now

@ghost ghost closed this as completed Apr 15, 2020
@unknownbrackets unknownbrackets removed this from the Future milestone Apr 15, 2020
@ghost ghost mentioned this issue Apr 26, 2022
5 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants