Indiana Jones and the Staff of Kings graphics issues (Mali, ES 2.0)

[hrydgard]

Originally reported here, on a Mali 400 device:

https://forums.ppsspp.org/showthread.php?tid=2301

Seems the graphics have broken at some point.

A frame dump would help, see https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

[ghost]

Look like a similar issue #11573 but different game

Screenshot

[ppmeis]

Tested on latest Windows build. It looks fine:

[ghost]

Disable Slower Effects ON

Disable Slower Effects OFF

Mali-450 GPU
PPSSPP-v1.7.5-438-gccfcbc746

[unknownbrackets]

The "disable slower effects" checkbox should possibly be renamed to "increase graphics bugs but also speed".

If it's only broken with slower effects disabled, it's not broken. It's working as well as possible.

-[Unknown]

[hrydgard]

Although in the post above, it looks like the opposite... Maybe confused ON/OFF?

[unknownbrackets]

Oh, my mistake. If this only happens on Mali-4xx, maybe it's a depal issue or else shader blending then? Maybe the shader fails due to shader complexity but then we copy the pixels anyway?

-[Unknown]

[hrydgard]

Yeah, that seems like a fairly likely explanation..

[ghost]

Just a reminder that this issue only can produce on a phone with opengl 2.0 mali 400 series gpu.

[hrydgard]

It's not a solved issue so I'm reluctant to close, it might get accidentally fixed by another fix in the future, but probably won't ever get around to digging deep here, so removing the milestone.

[unknownbrackets]

#11573 caused a similar issue to this one, and I noticed its dump produces some interesting artifacts in the software renderer. Leaving some notes here in case it's helpful.

Everything is fine through draw 111. For 112/151, it then textures that onto the depth buffer using src.a * src + zero, but this somehow leaves some gaps between the rectangles it drew. It then uses this for bloom, which makes some purple bleed all over the screen.

The x coordinates are 0.5 - 32.4375, 32.5 - 64.4375, etc. up through 240.4375. The y coordinates are similar, always 0.5 - 136.4375 for each rectangle. This is done in throughmode, so there's probably an issue with how these coordinates are rounding while in throughmode. If I adjust the offset for the draw, it rounds properly.

I'd guess the artifacting in this issue might be related to some sort of depth buffer usage too.

-[Unknown]

[10522]

@hrydgard, @unknownbrackets, is it possible to fix this problem?

[ghost]

@hrydgard, @unknownbrackets, is it possible to fix this problem?

Use v1.13.0 I think disable slower effects still available on that version.