Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split august and yale integrations #124677

Merged
merged 16 commits into from
Aug 28, 2024
Merged

Split august and yale integrations #124677

merged 16 commits into from
Aug 28, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 27, 2024 •
edited
Loading

Proposed change

Yale and August product lines have split into two separate companies and the APIs, authentication methods, servers, and systems are diverging enough that the integration needs to be split into two.

The full transition plan is at home-assistant/home-assistant.io#33890

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

bdraco and others added 14 commits July 31, 2024 13:50
@bdraco
Split august and yale integrations [part 1] (#122253)
336e37e 
* merge with dev

* Remove unused constant
@bdraco
Remove yale IPv6 workaround (#123409)
4b78341
@bdraco
Merge remote-tracking branch 'upstream/dev' into yale_august_split
5006126
@bdraco
Merge remote-tracking branch 'upstream/yale_august_split' into yale_a…
21a3c0a 
…ugust_split
@bdraco
Merge remote-tracking branch 'upstream/dev' into yale_august_split
8cd3f8f
@bdraco
Merge remote-tracking branch 'upstream/dev' into yale_august_split
1754a5f
@bdraco
Merge remote-tracking branch 'upstream/dev' into yale_august_split
6bb774a
@bdraco
Merge branch 'dev' into yale_august_split
9d30dfd
@bdraco
Merge remote-tracking branch 'upstream-ssh/dev' into yale_august_split
b5c08e1
@bdraco
Merge branch 'dev' into yale_august_split
102bc6a
@bdraco @joostlek
Convert yale to use oauth (#123806)
32db0bd 
Co-authored-by: Joost Lekkerkerker <[email protected]>
@bdraco
Merge remote-tracking branch 'upstream/dev' into yale_august_split
69adb94
@bdraco
Merge remote-tracking branch 'upstream/dev' into yale_august_split
9d16dc9
@bdraco
Merge remote-tracking branch 'upstream/dev' into yale_august_split
6c2b0c0
home-assistant[bot]

This comment was marked as outdated.

Sign in to view

@bdraco bdraco mentioned this pull request Aug 27, 2024
Merged
27 tasks
@bdraco bdraco dismissed home-assistant[bot]’s stale review August 27, 2024 07:42

this is a merge of an integration branch back to dev that has already been reviewed separately

@bdraco bdraco added this to the 2024.9.0b0 milestone Aug 27, 2024
@bdraco bdraco mentioned this pull request Aug 28, 2024
Merged
13 tasks
@bdraco bdraco marked this pull request as ready for review August 28, 2024 02:08
joostlek
joostlek requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions and little remarks, except for the duplicate config entry check there's nothing major for me (looking at deadline for beta)

homeassistant/components/yale/__init__.py Show resolved Hide resolved
homeassistant/components/yale/__init__.py Show resolved Hide resolved
homeassistant/components/yale/binary_sensor.py Show resolved Hide resolved
homeassistant/components/yale/config_flow.py Show resolved Hide resolved
homeassistant/components/yale/config_flow.py Show resolved Hide resolved
tests/components/yale/test_config_flow.py Show resolved Hide resolved
tests/components/yale/test_config_flow.py Show resolved Hide resolved
tests/components/yale/test_config_flow.py Show resolved Hide resolved
tests/components/yale/test_init.py Show resolved Hide resolved
tests/components/yale/test_init.py Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 28, 2024 12:18
@edenhaus edenhaus removed this from the 2024.9.0b0 milestone Aug 28, 2024
@bdraco bdraco marked this pull request as ready for review August 28, 2024 15:28
@home-assistant home-assistant bot requested a review from joostlek August 28, 2024 15:29
@bdraco
Copy link
Member Author

bdraco commented Aug 28, 2024

Nearly all review comments above also apply to the August integration since that is where most of the code originates. While I've spent months cleaning it up, there is still some legacy there. I could spend a few more weeks cleaning up the code/tests.

Still, this one is a difficult position since if we don't ship this; all the Yale Home users will likely stop working again because the old API key we are using will stop working permanently.

Since all the branches going into the integration branch have been reviewed, I suggest we merge this and address the comments in a follow-up.

@bdraco bdraco added this to the 2024.9.0 milestone Aug 28, 2024
@balloob
Copy link
Member

balloob commented Aug 28, 2024

I agree. This should be included in the release to avoid breaking users instances.

@balloob balloob merged commit 03ead27 into dev Aug 28, 2024
40 checks passed
@balloob balloob deleted the yale_august_split branch August 28, 2024 15:46
Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Aug 28, 2024
@bdraco @joostlek @Gigatrappeur
Split august and yale integrations (home-assistant#124677)
fab177a 
* Split august and yale integrations [part 1] (home-assistant#122253)

* merge with dev

* Remove unused constant

* Remove yale IPv6 workaround (home-assistant#123409)

* Convert yale to use oauth (home-assistant#123806)

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update yale for switch from pubnub to websockets (home-assistant#124675)

---------

Co-authored-by: Joost Lekkerkerker <[email protected]>
@bdraco bdraco mentioned this pull request Aug 28, 2024
Merged
19 tasks
@edenhaus edenhaus removed this from the 2024.9.0 milestone Aug 28, 2024
bdraco added a commit that referenced this pull request Aug 28, 2024
@bdraco
Address august review comments
e05213a 
Followup to #124677
This was referenced Aug 28, 2024
Merged
Merged
joostlek pushed a commit that referenced this pull request Aug 29, 2024
@bdraco
Address august review comments (#124819)
a04970b 
* Address august review comments

Followup to #124677

* cleanup loop

* drop mixin name

* event entity add cleanup

* remove duplicate prop

* pep0695 type

* remove some not needed block till done

* cleanup august tests

* switch to freezegun

* snapshots for dev reg

* SOURCE_USER nit

* snapshots

* pytest.raises

* not loaded check
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

@joostlek joostlek Awaiting requested review from joostlek

Assignees
No one assigned
Labels
by-code-owner cla-signed core has-tests integration: august integration: yale new-integration Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdraco @balloob @joostlek @edenhaus