Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address august review comments #124819

Merged
merged 14 commits into from
Aug 29, 2024
Merged

Address august review comments #124819

merged 14 commits into from
Aug 29, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 28, 2024

Proposed change

Followup to #124677

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2024.9.0 milestone Aug 28, 2024
@bdraco
Copy link
Member Author

bdraco commented Aug 28, 2024

tagging in case there are any conflicts

@bdraco bdraco marked this pull request as ready for review August 28, 2024 21:21
@joostlek joostlek merged commit a04970b into dev Aug 29, 2024
26 checks passed
@joostlek joostlek deleted the august_cleanups branch August 29, 2024 17:32
@bdraco
Copy link
Member Author

bdraco commented Aug 29, 2024

Thanks. I’ll do another turn on Yale later today to address the similar feedback in other test files

bramkragten pushed a commit that referenced this pull request Aug 30, 2024
* Address august review comments

Followup to #124677

* cleanup loop

* drop mixin name

* event entity add cleanup

* remove duplicate prop

* pep0695 type

* remove some not needed block till done

* cleanup august tests

* switch to freezegun

* snapshots for dev reg

* SOURCE_USER nit

* snapshots

* pytest.raises

* not loaded check
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants