Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ignore-missing-annotations from pylint #124316

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Aug 20, 2024

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Aug 20, 2024
@frenck
Copy link
Member

frenck commented Sep 10, 2024

We don't require things to be typed, I'm not sure if we should enforce that we do?

@epenet
Copy link
Contributor Author

epenet commented Sep 11, 2024

We don't require things to be typed, I'm not sure if we should enforce that we do?

This PR is not about forcing type hints everywhere.
It is only about enforcing when the type is known and/or obvious, and there is a long way to go before this PR is near ready...

Does that mean that #125322 (for config-flow) should be closed?
And what does it mean for #120302 (for tests): should that one be reverted?

@epenet epenet force-pushed the drop-ignore-missing-annotations branch from 71ce8ec to 2e24e5f Compare September 22, 2024 19:46
@epenet epenet force-pushed the drop-ignore-missing-annotations branch from 2e24e5f to c9cd471 Compare November 4, 2024 11:35
@frenck frenck force-pushed the drop-ignore-missing-annotations branch from c9cd471 to 86467e4 Compare November 8, 2024 20:35
@epenet epenet force-pushed the drop-ignore-missing-annotations branch from 86467e4 to 3f9fab1 Compare November 18, 2024 06:35
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@epenet epenet force-pushed the drop-ignore-missing-annotations branch from 2f601ca to f20be9a Compare March 4, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants