Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config flow type hints in sms #124352

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Aug 21, 2024

Proposed change

SSIA, linked to #124316

Also removed unused async_step_import, which appears to have been missed in #43484

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ocalvo, mind taking a look at this pull request as it has been labeled with an integration (sms) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sms can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sms Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet
Copy link
Contributor Author

epenet commented Aug 21, 2024

Sadly there is very little coverage on sms integration:

---------- coverage: platform linux, python 3.12.5-final-0 -----------
Name                                          Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------
homeassistant/components/sms/__init__.py         45     27    40%   48-50, 56-94, 99-104
homeassistant/components/sms/config_flow.py      51     51     0%   3-90
homeassistant/components/sms/const.py            12      0   100%
homeassistant/components/sms/coordinator.py      27     14    48%   21-27, 31-35, 43-49, 53-57
homeassistant/components/sms/gateway.py         130     72    45%   31-34, 42-46, 54-82, 115-116, 125-131, 139-145, 149, 153, 157, 161-167, 171, 175-181, 185-191, 195, 200-211
homeassistant/components/sms/notify.py           44     44     0%   3-85
homeassistant/components/sms/sensor.py           29     29     0%   3-120
---------------------------------------------------------------------------
TOTAL                                           338    237    30%

Comment on lines -82 to -85
async def async_step_import(self, user_input):
"""Handle import."""
return await self.async_step_user(user_input)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, as it appears to have been missed in #43484

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a follow up PR to, at least, add coverage for the config_flow.

LGTM,
Thanks @epenet 👍

@joostlek joostlek merged commit d4ae592 into home-assistant:dev Aug 28, 2024
24 of 26 checks passed
@epenet epenet deleted the 20240821-1131 branch August 28, 2024 11:04
Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Aug 28, 2024
* Improve config flow type hints in sms

* Drop async_step_import
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants