-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve config flow type hints in sms #124352
Conversation
Hey there @ocalvo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Sadly there is very little coverage on
|
async def async_step_import(self, user_input): | ||
"""Handle import.""" | ||
return await self.async_step_user(user_input) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, as it appears to have been missed in #43484
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's open a follow up PR to, at least, add coverage for the config_flow.
LGTM,
Thanks @epenet 👍
* Improve config flow type hints in sms * Drop async_step_import
Proposed change
SSIA, linked to #124316
Also removed unused
async_step_import
, which appears to have been missed in #43484Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: