Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pylint ignore_missing_annotations in config flow #125322

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Sep 5, 2024

Proposed change

SSIA, as a preliminary step for #124316

It would be nice to have these, but to avoid new violations maybe we should not wait:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Sep 5, 2024
@epenet epenet force-pushed the 20240905-1132 branch 2 times, most recently from d686451 to a9c248f Compare September 8, 2024 18:49
@epenet epenet marked this pull request as ready for review September 8, 2024 18:50
@epenet epenet requested review from starkillerOG and a team as code owners September 8, 2024 18:50
Copy link
Contributor Author

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three two one integrations with violations still - but I suggest that we merge it anyway with ignore statements - and fix the violations in subsequent PRs.
That would prevent new violations from creeping in.

@epenet epenet force-pushed the 20240905-1132 branch 2 times, most recently from 0984ada to 8f5478d Compare September 10, 2024 09:59
@epenet epenet marked this pull request as draft September 13, 2024 14:44
@epenet epenet marked this pull request as ready for review September 14, 2024 08:32
@epenet
Copy link
Contributor Author

epenet commented Sep 14, 2024

Rebased over #125313

@epenet
Copy link
Contributor Author

epenet commented Sep 14, 2024

A new one has crept in: monarch_money from #125322
@jeeftor could you take a look?

Edit: I opened #126019

@epenet epenet marked this pull request as draft September 16, 2024 06:13
@epenet epenet marked this pull request as ready for review September 16, 2024 08:23
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@epenet epenet merged commit 18e2c2f into home-assistant:dev Sep 16, 2024
44 checks passed
@epenet epenet deleted the 20240905-1132 branch September 16, 2024 10:08
bealex pushed a commit to DevPocket/homeassistant-core that referenced this pull request Sep 16, 2024
…ant#125322)

* Disable pylint ignore_missing_annotations in config flow

* Add tests

* Ignore point
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants