Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.6.4 #120114

Merged
merged 26 commits into from
Jun 21, 2024
Merged

2024.6.4 #120114

merged 26 commits into from
Jun 21, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 21, 2024

Release notes adjustments: home-assistant/home-assistant.io#33355

Kane610 and others added 24 commits June 21, 2024 10:55
* Fix for shared images

* - FIX: Synology shared photos

* - changes after review

* Added test

* added test

* fix test
* Implement correct passing fix

* Keep the test as is, as it simulates the current behavior

* Last minor change
* Always import HomeAssistantSpotifyData in spotify.media_browser

Relocate HomeAssistantSpotifyData to avoid circular import

* Fix moved import

* Rename module to 'models'

* Adjust docstring
fix gathering data from Canary sensors
* Bump plugwise to v0.37.4

* bump plugwise to v0.37.4.1
Getting soundField on soundbar that doesn't support it crash raise an exception, so it make the whole components unavailable. As there is no simple way to know if soundField is supported, I just get all sound settings, and then pick soundField one if present. If not present, then return None to make it continue, it will just have to effect to display no sound mode and not able to select one (Exactly what we want).
@home-assistant home-assistant bot added cla-signed core merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. labels Jun 21, 2024
@frenck
Copy link
Member Author

frenck commented Jun 21, 2024

Reached out to @Kane610, as the CI error is originating from unifi (which has a patch toward rc this release).

@frenck frenck marked this pull request as ready for review June 21, 2024 18:13
@frenck frenck merged commit b315b56 into master Jun 21, 2024
78 of 80 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.