Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi temp fix to handle runtime data #120031

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 20, 2024

Breaking change

Proposed change

Work around for release branch as a proper fix has been done on dev already (#119202) I think there are dependencies to other changes so that's why Im doing a separate fix here.

Solution proposed on issue #119159

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed integration: unifi merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. by-code-owner Quality Scale: platinum labels Jun 20, 2024
@frenck frenck added this to the 2024.6.4 milestone Jun 20, 2024
@Kane610
Copy link
Member Author

Kane610 commented Jun 20, 2024

Thanks @thecode 🎉

@frenck frenck merged commit 94800cb into home-assistant:rc Jun 21, 2024
22 of 24 checks passed
@Kane610 Kane610 deleted the unifi-temp_fix_to_handle_runtime_data branch June 21, 2024 16:19
@frenck frenck mentioned this pull request Jun 21, 2024
frenck added a commit that referenced this pull request Jun 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cherry-picked cla-signed integration: unifi merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants