Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UniFi services handle unloaded config entry #120028

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 20, 2024

Breaking change

Proposed change

Don't try to access runtime_data if config entry is not loaded

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2024.6.4 milestone Jun 20, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 20, 2024
Copy link
Contributor

@Bre77 Bre77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@frenck frenck merged commit 6fb5a12 into home-assistant:dev Jun 21, 2024
25 checks passed
@frenck frenck mentioned this pull request Jun 21, 2024
@frenck frenck removed this from the 2024.6.4 milestone Jun 21, 2024
@frenck
Copy link
Member

frenck commented Jun 21, 2024

I removed this one from the milestone; there are too many changes in the test at this point to make this one go in cleanly.

frenck added a commit that referenced this pull request Jun 21, 2024
@nathan-curtis
Copy link

@frenck does that mean this is NOT in 2024.6.4 (i just installed and am still having the issue) if so the relnotes for x.6.4 say the fix is still in...

@Kane610 Kane610 deleted the unifi-manage_entry_not_loaded_in_services branch June 22, 2024 07:47
@Kane610
Copy link
Member Author

Kane610 commented Jun 22, 2024

I removed this one from the milestone; there are too many changes in the test at this point to make this one go in cleanly.

Thanks @frenck

@Kane610
Copy link
Member Author

Kane610 commented Jun 22, 2024

@frenck does that mean this is NOT in 2024.6.4 (i just installed and am still having the issue) if so the relnotes for x.6.4 say the fix is still in...

Yes its not part of the latest release. It will be a part of next major release instead. The fix doesnt really change the behavior only avoid crashing the service call. You still need to make sure your integration is connected to the network app

@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants