-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024.4.1 #114934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix brightness values in light.py Bugfix to set the brightness to 0-100 which is what Lutron expects.
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Erik <[email protected]>
* Avoid blocking IO in downloader initialization * Avoid blocking IO in downloader initialization
Co-authored-by: TheJulianJES <[email protected]>
* Create right import issues in Downloader * Create right import issues in Downloader * Create right import issues in Downloader * Create right import issues in Downloader * Fix * Fix * Fix * Fix * Apply suggestions from code review Co-authored-by: Martin Hjelmare <[email protected]> * Fix --------- Co-authored-by: Martin Hjelmare <[email protected]>
joostlek
approved these changes
Apr 5, 2024
I'm not fully understanding why the tests are failing.
Locally the pass, and I do see MODE_SYSTEM locally as well. |
Aah probably related: timmo001/system-bridge-connector@a016acc |
Yup: #114842 Need to pull that one in. |
* Fix ROVA validation * Fix ROVA validation
balloob
approved these changes
Apr 5, 2024
Hmm, any reason #114832 was not included as proposed by related closed issues? |
Whoops, I forgot to tag it to the milestone |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
has-tests
merging-to-master
This PR is merging into the master branch and should probably change the branch to `dev`.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyError
during Notion setup (@bachya - #114787) (notion docs)Release notes: home-assistant/home-assistant.io#32172