Fix Downloader YAML import #114844
Fix Downloader YAML import #114844
Conversation
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: downloader
small-pr
|
Hey there @erwindouna, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
changed the title
| @@ -43,6 +43,13 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool: | |||
| if DOMAIN not in config: | |||
| return True | |||
|
|
|||
| hass.async_create_task(_async_import_config(hass, config), eager_start=True) | |||
There was a problem hiding this comment.
I don't think eager start makes sense since the component needs to be setup before the config entry is setup, and the config entry will be setup at the end of the config flow. We know that the task will need to yield to the loop to wait for the component setup to complete if we use an eager task. The whole point of this task is that we want it to run in a later iteration of the event loop to avoid a deadlock.
There was a problem hiding this comment.
Bdraco had it in his comment, do we want to remove it before the hotfix cut?
There was a problem hiding this comment.
It's not a bug it's just confusing.
Proposed change
Avoid deadlock on import of config YAML.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: