Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce august polling frequency #114904

Merged
merged 9 commits into from
Apr 5, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 4, 2024

Proposed change

Since most data comes in via pubnub and we only need the battery status from the lock detail API we can reduce the polling to every 24 hours instead of every hour per lock.

Additionally the activity polls are reduced since each lock wakes up at startup and would poll the activity api. We now avoid the additional polling (which is for the doorbells) during the first 60 seconds since it could generate 3*number of locks calls to the activity api

The polling was overloading the vendor's API.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Since most data comes in via pubnub and we only need the battery
status from the lock detail API we can reduce the polling to
every 24 hours instead of every hour per lock.
@bdraco bdraco marked this pull request as ready for review April 4, 2024 23:13
@bdraco bdraco changed the title Reduce august lock detail update frequency Reduce august polling frequency Apr 4, 2024
homeassistant/components/august/activity.py Outdated Show resolved Hide resolved
homeassistant/components/august/activity.py Outdated Show resolved Hide resolved
@bdraco bdraco merged commit 78920e1 into dev Apr 5, 2024
20 checks passed
@bdraco bdraco deleted the reduce_lock_detail_update_frequency branch April 5, 2024 01:28
frenck pushed a commit that referenced this pull request Apr 5, 2024
@frenck frenck mentioned this pull request Apr 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants