-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce august polling frequency #114904
Merged
Merged
Reduce august polling frequency #114904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since most data comes in via pubnub and we only need the battery status from the lock detail API we can reduce the polling to every 24 hours instead of every hour per lock.
home-assistant
bot
added
cla-signed
integration: august
small-pr
PRs with less than 30 lines.
labels
Apr 4, 2024
bdraco
commented
Apr 4, 2024
bdraco
changed the title
Reduce august lock detail update frequency
Reduce august polling frequency
Apr 4, 2024
TheJulianJES
approved these changes
Apr 5, 2024
Co-authored-by: TheJulianJES <[email protected]>
Co-authored-by: TheJulianJES <[email protected]>
frenck
pushed a commit
that referenced
this pull request
Apr 5, 2024
Co-authored-by: TheJulianJES <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cherry-picked
cla-signed
integration: august
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Since most data comes in via pubnub and we only need the battery status from the lock detail API we can reduce the polling to every 24 hours instead of every hour per lock.
Additionally the activity polls are reduced since each lock wakes up at startup and would poll the activity api. We now avoid the additional polling (which is for the doorbells) during the first 60 seconds since it could generate 3*number of locks calls to the activity api
The polling was overloading the vendor's API.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: