Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Token Claim Airdrop with receiverSigReq test #15279

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Aug 30, 2024

Description:
Adding test for token claim with recSigReq and multiple tokens (CLAIM_25 from test plan)

Related issue(s):
#14933
Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (db414c7) to head (4a2f7c9).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15279   +/-   ##
==========================================
  Coverage      57.23%   57.23%           
  Complexity     22026    22026           
==========================================
  Files           2912     2912           
  Lines         113051   113051           
  Branches       11526    11526           
==========================================
  Hits           64708    64708           
  Misses         44459    44459           
  Partials        3884     3884           

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (db414c7) 112867 68480 60.67%
Head commit (4a2f7c9) 112867 (+0) 68480 (+0) 60.67% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15279) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ibankov

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ibankov

@Neeharika-Sompalli Neeharika-Sompalli merged commit 2954bdc into develop Aug 30, 2024
77 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 14933-claim-receiver-sig branch August 30, 2024 21:46
netopyr added a commit that referenced this pull request Sep 5, 2024
* develop: (727 commits)
  chore: Bump services version to 0.55 (#15321)
  fix: Prevent designating deleted accounts as custom fee collectors (#15339)
  chore: add unit tests for `ServicesSoftwareVersion` utilities (#15326)
  chore: Remove the script forensic/start-investigation.py (#14264)
  ci: disable release 0.52 regression (#15228)
  chore: Integrate protobufs to build (#15324)
  fix: stop using raw types in `Call{Attempt,Translator}`  (#15331)
  chore: Refactor and Remove Duplicate Documentation in Services (#15286)
  feat: 15146 Added `calculateHash`, `setHash` and `getHash` methods to `State` interface (#15274)
  fix: 10342: HashListByteBuffer releases DirectByteBuffers lazily, adds memory pressure (#15296)
  fix: if the directory exist, don't create it in UnzipUtility (#15319)
  fix: use `ServicesSoftwareVersion` (#15294)
  test: add a sigRequired true additional test (#15267)
  fix: code style and javadoc fixes (#15298)
  chore: remove 'itest' test set (#15276)
  chore: rename directory 'swirlds-jasperdb' to 'swirlds-merkledb' (#15143)
  test: Token Claim Airdrop with receiverSigReq test (#15279)
  chore: 11771 Added more unit tests for `WritablePlatformStateStore` (#15268)
  chore: remove unused `hedera-evm-*` and `cli-clients` modules (#15271)
  docs: tss ledger id platform design proposal (#13747)
  ...

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/cache/CacheWarmer.java
rbarker-dev pushed a commit that referenced this pull request Sep 5, 2024
stoyanov-st pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants