Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 11771 Added more unit tests for WritablePlatformStateStore #15268

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

imalygin
Copy link
Contributor

Description:

This PR adds more unit tests for WritablePlatformStateStore.

Related issue(s):

Relates to #11771

@imalygin imalygin added the Test Development Test Development label Aug 29, 2024
@imalygin imalygin added this to the v0.54 milestone Aug 29, 2024
@imalygin imalygin self-assigned this Aug 29, 2024
@imalygin imalygin requested a review from a team as a code owner August 29, 2024 21:02
@imalygin imalygin requested a review from lpetrovic05 August 29, 2024 21:02
Copy link

codacy-production bot commented Aug 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4d517d6) 112854 68470 60.67%
Head commit (7af6e2e) 112981 (+127) 68618 (+148) 60.73% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15268) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.30%. Comparing base (4d517d6) to head (7af6e2e).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15268      +/-   ##
=============================================
+ Coverage      57.23%   57.30%   +0.06%     
- Complexity     22019    22052      +33     
=============================================
  Files           2912     2920       +8     
  Lines         113038   113165     +127     
  Branches       11520    11534      +14     
=============================================
+ Hits           64694    64844     +150     
+ Misses         44456    44435      -21     
+ Partials        3888     3886       -2     

see 30 files with indirect coverage changes

Impacted file tree graph

litt3
litt3 previously approved these changes Aug 30, 2024
@imalygin imalygin merged commit ab211b3 into develop Aug 30, 2024
55 checks passed
@imalygin imalygin deleted the 11771-more-tests-for-platform-state branch August 30, 2024 19:46
netopyr added a commit that referenced this pull request Sep 5, 2024
* develop: (727 commits)
  chore: Bump services version to 0.55 (#15321)
  fix: Prevent designating deleted accounts as custom fee collectors (#15339)
  chore: add unit tests for `ServicesSoftwareVersion` utilities (#15326)
  chore: Remove the script forensic/start-investigation.py (#14264)
  ci: disable release 0.52 regression (#15228)
  chore: Integrate protobufs to build (#15324)
  fix: stop using raw types in `Call{Attempt,Translator}`  (#15331)
  chore: Refactor and Remove Duplicate Documentation in Services (#15286)
  feat: 15146 Added `calculateHash`, `setHash` and `getHash` methods to `State` interface (#15274)
  fix: 10342: HashListByteBuffer releases DirectByteBuffers lazily, adds memory pressure (#15296)
  fix: if the directory exist, don't create it in UnzipUtility (#15319)
  fix: use `ServicesSoftwareVersion` (#15294)
  test: add a sigRequired true additional test (#15267)
  fix: code style and javadoc fixes (#15298)
  chore: remove 'itest' test set (#15276)
  chore: rename directory 'swirlds-jasperdb' to 'swirlds-merkledb' (#15143)
  test: Token Claim Airdrop with receiverSigReq test (#15279)
  chore: 11771 Added more unit tests for `WritablePlatformStateStore` (#15268)
  chore: remove unused `hedera-evm-*` and `cli-clients` modules (#15271)
  docs: tss ledger id platform design proposal (#13747)
  ...

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/cache/CacheWarmer.java
rbarker-dev pushed a commit that referenced this pull request Sep 5, 2024
stoyanov-st pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Development Test Development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants