chore: remove 'itest' test set #15276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only 4 test classes in this set in the whole code base. Nothing has been added since more than a year. Since these were separate, they did not run on CI for several months. This moves the few tests we have into the default "test" set (the tests do not take long to run). There will be the opportunity to sort tests into more categories if needed in a next step when the current CITR effort (#14407) moves forward. Signed-off-by: Jendrik Johannes <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15276 +/- ##
=============================================
+ Coverage 57.23% 57.35% +0.12%
- Complexity 22026 22060 +34
=============================================
Files 2912 2912
Lines 113051 113051
Branches 11526 11526
=============================================
+ Hits 64708 64846 +138
+ Misses 44459 44313 -146
- Partials 3884 3892 +8 see 26 files with indirect coverage changes |
tinker-michaelj
approved these changes
Sep 2, 2024
netopyr
added a commit
that referenced
this pull request
Sep 5, 2024
* develop: (727 commits) chore: Bump services version to 0.55 (#15321) fix: Prevent designating deleted accounts as custom fee collectors (#15339) chore: add unit tests for `ServicesSoftwareVersion` utilities (#15326) chore: Remove the script forensic/start-investigation.py (#14264) ci: disable release 0.52 regression (#15228) chore: Integrate protobufs to build (#15324) fix: stop using raw types in `Call{Attempt,Translator}` (#15331) chore: Refactor and Remove Duplicate Documentation in Services (#15286) feat: 15146 Added `calculateHash`, `setHash` and `getHash` methods to `State` interface (#15274) fix: 10342: HashListByteBuffer releases DirectByteBuffers lazily, adds memory pressure (#15296) fix: if the directory exist, don't create it in UnzipUtility (#15319) fix: use `ServicesSoftwareVersion` (#15294) test: add a sigRequired true additional test (#15267) fix: code style and javadoc fixes (#15298) chore: remove 'itest' test set (#15276) chore: rename directory 'swirlds-jasperdb' to 'swirlds-merkledb' (#15143) test: Token Claim Airdrop with receiverSigReq test (#15279) chore: 11771 Added more unit tests for `WritablePlatformStateStore` (#15268) chore: remove unused `hedera-evm-*` and `cli-clients` modules (#15271) docs: tss ledger id platform design proposal (#13747) ... # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/cache/CacheWarmer.java
rbarker-dev
pushed a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Jendrik Johannes <[email protected]>
stoyanov-st
pushed a commit
that referenced
this pull request
Sep 12, 2024
Signed-off-by: Jendrik Johannes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There are only 4 test classes in this set in the whole code base. Nothing has been added since more than a year.
Since these were separate, they did not run on CI for several months.
This moves the few tests we have into the default "test" set (the tests do not take long to run).
There will be the opportunity to sort tests into more categories if needed in a next step as the current CITR effort (#14407) moves forward.
Related issue(s):
#11564
Notes for reviewer:
Checklist