Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helix-specific ignore files #8099

Merged
merged 6 commits into from
Oct 21, 2023
Merged

Add helix-specific ignore files #8099

merged 6 commits into from
Oct 21, 2023

Conversation

PaulOlteanu
Copy link
Contributor

Fixes #7423

I chose .hxignore as the file name to match other tools such as ripgrep's .rgignore, but this is open to suggestions

@poliorcetics
Copy link
Contributor

I would much prefer .helix/ignore for two reasons:

  1. We could have one in the global config directory that always apply, making it easy to ignore common but useless files
  2. It would integrate with the existing .helix machinery, making less clutter (there is now .helix and .hxignore, when it already should always be .config/hx/...)

helix-view/src/editor.rs Outdated Show resolved Hide resolved
@pascalkuthe
Copy link
Member

I think you could add the gloabl ignore file (see #8300) right in this PR too, so we can get this done in one go

@SecretPocketCat
Copy link

I think you could add the gloabl ignore file (see #8300) right in this PR too, so we can get this done in one go

I thought these were orthogonal, so I created a new PR for the global file. Either way I'll be happy. Should I close #8300 then?

@pascalkuthe pascalkuthe added E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-command Area: Commands labels Oct 19, 2023
@the-mikedavis the-mikedavis changed the title Add a helix-specific ignore file Add helix-specific ignore files Oct 21, 2023
@the-mikedavis the-mikedavis merged commit 8d44459 into helix-editor:master Oct 21, 2023
6 checks passed
@gamma-delta
Copy link
Contributor

Hello, just like to add my two cents here -- I'm using Helix as my editor for C# in Godot and the ability to mask out all the .import and .tscn files and so on would be amazing, especially because for LSP reasons I need to have Helix's origin directory be the root of the project. :)

danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
@David-Else
Copy link
Contributor

@PaulOlteanu Hi, I have read the docs at https://docs.helix-editor.com/master/configuration.html?highlight=ignore#editorfile-picker-section, and it mentions a .ignore file, but if I want a global ignore file in my config dir then I need to use a ignore file, am i misunderstanding something or is this some kind of error? There seems to be no mention in the docs of a ignore file, and a .ignore file works in my local directory. Should the global ignore file not also have a . in front of it?

@the-mikedavis
Copy link
Member

It looks like we don't document these new files anywhere yet. That section in the docs could mention that you can use ignore files with a local .ignore, ~/.ignore or now .helix/ignore and ~/.config/helix/ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helix-specific ignore file
7 participants