Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to define dotfiles to be exposed in file picker #5924

Closed

Conversation

KenCox94
Copy link

completed to resolve #5724

@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 13, 2023
@penguincoder
Copy link

Can you help me understand how to use this? I am personally pretty vested in this feature since I am doing an absolute ton of work with Github Actions right now. I have cloned your branch, then built and installed it. I have tried leaving the default configuration in place and putting both include-hidden = [".github"] and include-hidden = ["github"].

When I open the file picker <space>f and then try and type .github/workflows, by the time I hit the / the file picker is completely empty. Oddly enough, .gitignore works okay, but not .github.

Am I missing something?

@KenCox94
Copy link
Author

KenCox94 commented Jun 6, 2023

Can you help me understand how to use this? I am personally pretty vested in this feature since I am doing an absolute ton of work with Github Actions right now. I have cloned your branch, then built and installed it. I have tried leaving the default configuration in place and putting both include-hidden = [".github"] and include-hidden = ["github"].

When I open the file picker <space>f and then try and type .github/workflows, by the time I hit the / the file picker is completely empty. Oddly enough, .gitignore works okay, but not .github.

Am I missing something?

Let me take a look at this today and I'll get back with you tomorrow! Just letting you know I did see it.

@KenCox94
Copy link
Author

KenCox94 commented Jun 8, 2023

Can you help me understand how to use this? I am personally pretty vested in this feature since I am doing an absolute ton of work with Github Actions right now. I have cloned your branch, then built and installed it. I have tried leaving the default configuration in place and putting both include-hidden = [".github"] and include-hidden = ["github"].

When I open the file picker <space>f and then try and type .github/workflows, by the time I hit the / the file picker is completely empty. Oddly enough, .gitignore works okay, but not .github.

Am I missing something?

I think this may be because .github is a directory and .gitignore, .gitattributes are files? Let me investigate this further and Ill try and have a fix for this by this weekend!

@KenCox94
Copy link
Author

KenCox94 commented Jun 9, 2023

@penguincoder fixed it!

you wont need .github in your config.yaml as it was requested as a default

@penguincoder
Copy link

That is the ticket! It's working very well now, thanks!

I guess it's not a typical workflow to have a hidden directory that you need to edit a lot of files in.

@penguincoder
Copy link

Has there been any progress on this? Do you just need to have it reviewed? I have been using this for the past month(s) and it's been working great. Thanks again!

@KenCox94
Copy link
Author

@penguincoder
as far as I know. Im just waiting on a review. It's saying my merge is blocked due to that.

@pascalkuthe
Copy link
Member

This is covered by #7423 (with negative ignore patterns both globally and pre workspace). I don't see us adding anything more purpose-built than that

@pascalkuthe
Copy link
Member

closing as #8099 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global dot and hidden files/directories include for file picker
5 participants