Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix-specific ignore file #7423

Closed
rcorre opened this issue Jun 22, 2023 · 3 comments · Fixed by #8099
Closed

Helix-specific ignore file #7423

rcorre opened this issue Jun 22, 2023 · 3 comments · Fixed by #8099
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@rcorre
Copy link
Contributor

rcorre commented Jun 22, 2023

I'm working in a project with lots of .blend files. These are committed to version control (so they're not in .gitignore). I also find it useful to type blender <ctrl+t>, using fzf to select a blend file to open, so I don't want to add .blend to .ignore. However, I don't want these files to show up in the helix file picker. Could we have helix respect an additional ignore file, .helix/ignore? This would contain patterns that should be ignored by helix, but not other tools that also use .ignore.

@rcorre rcorre added the C-enhancement Category: Improvements label Jun 22, 2023
@rcorre
Copy link
Contributor Author

rcorre commented Jun 22, 2023

Alternatively, an option to ignore binary files in the picker would also work here.

@pppKin
Copy link
Contributor

pppKin commented Jun 27, 2023

Alternatively, an option to ignore binary files in the picker would also work here.

If we go with this, it should default to true IMO.

@PaulOlteanu
Copy link
Contributor

PaulOlteanu commented Aug 25, 2023

Filtering the file picker seems to be done by file extension at the moment (for compressed files). Looking into how ripgrep filters binary files shows that it does so by finding a NUL byte in the file, and copying this behaviour would mean the file picker would have to start reading each file (which doesn't seem like a good solution imo)

We could try and create a big list of binary file extensions for this purpose.

I can take a look at adding support for a .helix/ignore solution though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants