Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OtherIO.can_read method to tests #102

Merged
merged 3 commits into from
Jul 1, 2023
Merged

Add OtherIO.can_read method to tests #102

merged 3 commits into from
Jul 1, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 1, 2023

Motivation

Adding OtherIO.can_read is necessary once hdmf-dev/hdmf#875 is merged.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel July 1, 2023 08:33
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (531296c) 82.00% compared to head (45498a8) 81.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #102      +/-   ##
==========================================
- Coverage   82.00%   81.99%   -0.02%     
==========================================
  Files          11       11              
  Lines        2657     2660       +3     
==========================================
+ Hits         2179     2181       +2     
- Misses        478      479       +1     
Impacted Files Coverage Δ
tests/unit/base_tests_zarrio.py 98.62% <66.66%> (-0.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rly rly merged commit 6a3474e into dev Jul 1, 2023
@rly rly deleted the rly-patch-2 branch July 1, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants