Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OtherIO.can_read method to tests #102

Merged
merged 3 commits into from
Jul 1, 2023
Merged

Add OtherIO.can_read method to tests #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f21031
Add OtherIO.can_read method to tests
rly Jul 1, 2023
38bbba0
Update CHANGELOG.md
rly Jul 1, 2023
45498a8
Update CHANGELOG.md
rly Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,21 @@

### New Features
* Added support, tests, and docs for using ``DirectoryStore``, ``TempStore``, and
``NestedDirectoryStore`` Zarr storage backends with ``ZarrIO`` and ``NWBZarrIO``
``NestedDirectoryStore`` Zarr storage backends with ``ZarrIO`` and ``NWBZarrIO``.
@oruebel [#62](https://github.com/hdmf-dev/hdmf-zarr/pull/62)

### Minor enhancements
* Updated handling of references on read to simplify future integration of file-based Zarr
stores (e.g., ZipStore or database stores) @oruebel [#62](https://github.com/hdmf-dev/hdmf-zarr/pull/62)
* Added can_read classmethod to ZarrIO. @bendichter [#97](https://github.com/hdmf-dev/hdmf-zarr/pull/97)
stores (e.g., ZipStore or database stores). @oruebel [#62](https://github.com/hdmf-dev/hdmf-zarr/pull/62)
* Added ``can_read`` classmethod to ``ZarrIO``. @bendichter [#97](https://github.com/hdmf-dev/hdmf-zarr/pull/97)

### Test suite enhancements
* Modularized unit tests to simplify running tests for multiple Zarr storage backends
* Modularized unit tests to simplify running tests for multiple Zarr storage backends.
@oruebel [#62](https://github.com/hdmf-dev/hdmf-zarr/pull/62)
* Updated tests to handle upcoming changes to ``HDMFIO``. @rly [#102](https://github.com/hdmf-dev/hdmf-zarr/pull/102)

### Docs
* Added developer documentation on how to integrate new storage backends with ZarrIO
* Added developer documentation on how to integrate new storage backends with ZarrIO. @oruebel
[#62](https://github.com/hdmf-dev/hdmf-zarr/pull/62)

### API Changes
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/base_tests_zarrio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,10 @@ def test_non_manager_container(self):

class OtherIO(HDMFIO):

@staticmethod
def can_read(path):
pass

def read_builder(self):
pass

Expand Down