Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add can_read method to HDMFIO and HDF5IO #875

Merged
merged 10 commits into from
Jul 10, 2023
Merged

add can_read method to HDMFIO and HDF5IO #875

merged 10 commits into from
Jul 10, 2023

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Jun 17, 2023

Motivation

NeurodataWithoutBorders/pynwb#859 (comment)

linked to hdmf-dev/hdmf-zarr#97

How to test the behavior?

HDF5IO.can_read("file.nwb") == True

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter bendichter requested review from oruebel and mavaylon1 June 17, 2023 00:23
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.33 ⚠️

Comparison is base (6b1a55f) 88.28% compared to head (c221009) 86.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #875      +/-   ##
==========================================
- Coverage   88.28%   86.95%   -1.33%     
==========================================
  Files          45       45              
  Lines        9242     9252      +10     
  Branches     2641     2644       +3     
==========================================
- Hits         8159     8045     -114     
- Misses        765      883     +118     
- Partials      318      324       +6     
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5tools.py 82.54% <100.00%> (+0.17%) ⬆️
src/hdmf/backends/io.py 96.15% <100.00%> (+0.04%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bendichter bendichter requested a review from rly June 18, 2023 16:12
rly
rly previously approved these changes Jun 19, 2023
rly
rly previously approved these changes Jul 1, 2023
@rly rly merged commit 1c7895f into dev Jul 10, 2023
@rly rly deleted the can_read branch July 10, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants