Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfixes #131

Merged
merged 7 commits into from
Mar 26, 2023
Merged

Minor bugfixes #131

merged 7 commits into from
Mar 26, 2023

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Jan 7, 2023

PR #130 precedes this PR

Proposed Changes

See commits:

  • fix: jq: error (at :1): Cannot iterate over null (null)
  • fix: unnecessary "true" or "false" log entry

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Feb 11, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Feb 11, 2023

Not stale, waiting for review/merge...

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Feb 12, 2023
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 14, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Mar 14, 2023

Not stale, waiting for review/merge...

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Mar 15, 2023
LICENSE.md Outdated
@@ -1,6 +1,6 @@
# MIT License

Copyright (c) 2021-2022 Franck Nijhof
Copyright (c) 2021-2023 Franck Nijhof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change for this PR

@@ -35,7 +35,7 @@ for address in "${addresses[@]}"; do
done

# Get configured tags
tags=$(bashio::config "tags | join(\",\")" "")
tags=$(bashio::config "tags//[] | join(\",\")" "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@frenck
Copy link
Member

frenck commented Mar 26, 2023

Rebased the PR, and removed the unrelated documentation changes.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Mar 26, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit 4b10a2c into hassio-addons:main Mar 26, 2023
@lmagyar lmagyar deleted the minor-bugfixes branch March 27, 2023 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants