-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Tailscale's builtin inbound HTTPS proxy #137
Enable Tailscale's builtin inbound HTTPS proxy #137
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
not stale |
6abd150
to
7ec02a8
Compare
I force pushed a rebase onto the lates PR #133, because with tailscale 1.38.1 some script changes are required. So this PR works only after that is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR references a lot, but it doesn't describe what it does.
7ec02a8
to
7d8c03c
Compare
I stashed and rebased it. This is an optional functionality, if the user doesn't configure anything, it works as previously, but emits some info log messages, that it can be configured and used. If configured, this solves the unsecure connection problem (I know, it's secure, only the browsers have problem with it): downloads and regularly refreshes a tailscale certificate for our tailnet and fires up it's own built-in proxy. |
I tried to keep this add-on as zero-config as it was, all the configuration is done on the tailscale admin web UI. |
7d8c03c
to
3bd3da5
Compare
I've rebased and rewritten as requested. Also tested manually the proxy startup logic and some corner cases on real devices. |
@lmagyar I'm looking forward to the PR 👍 |
@frenck Do you think it's possible to do a (beta) release this week? I would/could test it over the long Easter weekend :) |
@MelleD Not sure, right now, the Home Assistant Core release has my priority this week. |
@MelleD You can test it with installing my forked repo, more test is better: https://github.com/lmagyar/homeassistant-addon-tailscale |
Ok great, I'll try that 👍 |
e802721
to
91b849a
Compare
Short feedback: |
91b849a
to
8b0eb07
Compare
FYI:
The "how to make it customizable" review is still relevant/open. I also plan to PR the Funnel feature after this PR settled. |
c5f6fb3
to
134e5ee
Compare
FYI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lmagyar 👍
../Frenck
Replaces PR #89 #134
Proposed Changes
This is a better solution to the #62 issue than #89 #134 because it doesn't need any manual configuration and also provides a built-in proxy for the https traffic. We don't need to refresh the certificates manually, this is all done by tailscale automatically.
Related Issues
Fixes #62