Advertise all supported interfaces as Tailscale Subnets #135
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmagyar
changed the title
lmagyar
force-pushed
the
advertise-all-subnets
branch
2 times, most recently
from
5f3df99 to
e60839f
Compare
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Not stale, waiting for review/merge... |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Not stale, waiting for review/merge... |
github-actions
bot
removed
the
stale
frenck
requested changes
Mar 25, 2023
Comment on lines
12
to
21
| function list::contains() { | ||
| local list=${1} | ||
| local item=${2} | ||
|
|
||
| if [[ "${list}" =~ (^|[[:space:]])"${item}"($|[[:space:]]) ]]; then | ||
| return 0 | ||
| else | ||
| return 1 | ||
| fi | ||
| } |
There was a problem hiding this comment.
Right, I finally used sort -u.
lmagyar
force-pushed
the
advertise-all-subnets
branch
from
e60839f to
1072d28
Compare
frenck
added
the
enhancement
frenck
added
the
minor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives PR #116
Fixes #96
Proposed Changes
Advertise all supported interfaces as Tailscale Subnets not only the default interface.
Related Issues
#96