Precise Haddock: Use Avails for export resolution

[alexbiehl]

Since ghc/ghc@7e5d4a0 GHC holds the Avails for each export list entry. This patch makes use of these Avails so it doesn't have to calculate all the reexported names ourselves.

This resolves

• Support export of modules using their "as" name #121
• Haddock should hide hidden fields of re-exported modules #174
• no documentation for re-exported renamed modules #225
• Re-exports with PackageImports are not hyperlinkt #344
• Bugs in Haskell-level Re-exports #584
• Hidden constructors are exposed when using module reexports #591

[gbaz]

With this merged, should the linked issues be closed?

[gbaz]

(also -- does this help #17 at all?)

[alexbiehl]

(@gbaz yes and yes, with ghc/ghc@7e5d4a0#diff-b41195d34cc67bd181b2517f2010505a we know exactly which names are exported by which entry in the export list. If we find a module export we look at the import to check if the import is qualified or not. If it is we use the Avails associated with the module export entry. If it is unqualified we render the classic, full module export)

[gbaz]

final question -- does this fix #223 ?

[alexbiehl]

Yes, I guess gbaz <[email protected]> schrieb am Mo., 5. Feb. 2018, 10:06:

…

final question -- does this fix #223 <#223> ? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#688 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AByiiZO9qtwM24iG7ouWrQPBXVx3l5dzks5tRsSKgaJpZM4Ptpfg> .

[tfausak]

Thanks so much for fixing this long-standing bug, @alexbiehl! 🎉

[hvr]

So I guess encouraging publicly Haddock's maintainership pays off...

[tfausak]

I guess it does! I am very happy that this bug is fixed. Thanks again for taking the time to fix it, Alex! https://twitter.com/taylorfausak/status/960493800429883392