Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Hidden constructors are exposed when using module reexports #591

Closed
nikita-volkov opened this issue Mar 17, 2017 · 3 comments
Closed

Hidden constructors are exposed when using module reexports #591

nikita-volkov opened this issue Mar 17, 2017 · 3 comments

Comments

@nikita-volkov
Copy link

Here are the generated docs:
image

Here's the code for that module. You can see that the constructors are hidden.
image

A GHCI session proves that they are in fact hidden:

image

The associated code is here:
https://github.com/sannsyn/solr/tree/c49701f422c1ed21689757917548964ac312d4e8
@alexbiehl
Copy link
Member

I bet this is another short coming of haddocks export logic. See #584 for another example. @ezyang proposed a solution in #586 but it got stuck in some detail about documentation on exports I think. I intend to take a look at some point.

@ezyang
Copy link
Contributor

ezyang commented Mar 20, 2017

I think what may be the right thing to do is to extend the renamed IE syntax to also record "expansions" for T(..) and module Foo style exports, so that Haddock can directly read off what is brought into scope, rather than try to recompute it (poorly).

bgamari pushed a commit to bgamari/ghc that referenced this issue Sep 5, 2017
@alexbiehl @bgamari
Remember the AvailInfo for each IE
f609374 
This is another take on https://phabricator.haskell.org/D3844.

This patch removes then need for haddock to reimplement the calculation
of exported names from modules. Instead when renaming export lists ghc
annotates each IE with its exported names.

Haddocks current  export logic has caused lots of trouble in the past
(on the Github issue tracker):
  - haskell/haddock#121
  - haskell/haddock#174
  - haskell/haddock#225
  - haskell/haddock#344
  - haskell/haddock#584
  - haskell/haddock#591
  - haskell/haddock#597

Reviewers: austin, bgamari, ezyang

Reviewed By: bgamari, ezyang

Subscribers: rwbarton, thomie

Differential Revision: https://phabricator.haskell.org/D3864
bgamari pushed a commit to bgamari/ghc that referenced this issue Sep 5, 2017
@alexbiehl @bgamari
Remember the AvailInfo for each IE
1f71b39 
This is another take on https://phabricator.haskell.org/D3844.

This patch removes then need for haddock to reimplement the calculation
of exported names from modules. Instead when renaming export lists ghc
annotates each IE with its exported names.

Haddocks current  export logic has caused lots of trouble in the past
(on the Github issue tracker):
  - haskell/haddock#121
  - haskell/haddock#174
  - haskell/haddock#225
  - haskell/haddock#344
  - haskell/haddock#584
  - haskell/haddock#591
  - haskell/haddock#597

Reviewers: austin, bgamari, ezyang

Reviewed By: bgamari, ezyang

Subscribers: rwbarton, thomie

Differential Revision: https://phabricator.haskell.org/D3864
bgamari pushed a commit to bgamari/ghc that referenced this issue Sep 5, 2017
@alexbiehl @bgamari
Remember the AvailInfo for each IE
1e1ab24 
This is another take on https://phabricator.haskell.org/D3844.

This patch removes then need for haddock to reimplement the calculation
of exported names from modules. Instead when renaming export lists ghc
annotates each IE with its exported names.

Haddocks current  export logic has caused lots of trouble in the past
(on the Github issue tracker):
  - haskell/haddock#121
  - haskell/haddock#174
  - haskell/haddock#225
  - haskell/haddock#344
  - haskell/haddock#584
  - haskell/haddock#591
  - haskell/haddock#597

Reviewers: austin, bgamari, ezyang

Reviewed By: bgamari, ezyang

Subscribers: rwbarton, thomie

Differential Revision: https://phabricator.haskell.org/D3864
ghc-mirror pushed a commit to ghc/ghc that referenced this issue Sep 5, 2017
@alexbiehl @bgamari
Remember the AvailInfo for each IE
7e5d4a0 
This is another take on https://phabricator.haskell.org/D3844.

This patch removes then need for haddock to reimplement the calculation
of exported names from modules. Instead when renaming export lists ghc
annotates each IE with its exported names.

Haddocks current  export logic has caused lots of trouble in the past
(on the Github issue tracker):
  - haskell/haddock#121
  - haskell/haddock#174
  - haskell/haddock#225
  - haskell/haddock#344
  - haskell/haddock#584
  - haskell/haddock#591
  - haskell/haddock#597

Updates haddock submodule.

Reviewers: austin, bgamari, ezyang

Reviewed By: bgamari, ezyang

Subscribers: rwbarton, thomie

Differential Revision: https://phabricator.haskell.org/D3864
@alexbiehl alexbiehl mentioned this issue Oct 7, 2017
Merged
@gbaz
Copy link
Contributor

gbaz commented Feb 5, 2018

should be resolved by #688

@gbaz gbaz closed this as completed Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ezyang @gbaz @nikita-volkov @alexbiehl