This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 238
Bugs in Haskell-level Re-exports #584
Comments
This was referenced May 7, 2017
nkpart
added a commit
to nkpart/papa
that referenced
this issue
Sep 4, 2017
We're kind of hamstrung by a number of bugs in haddock, a few of which you can find here: haskell/haddock#584 Everything now has haddocks except for Papa.Lens.Export, which will need an explicit export list to work.
bgamari
pushed a commit
to bgamari/ghc
that referenced
this issue
Sep 5, 2017
This is another take on https://phabricator.haskell.org/D3844. This patch removes then need for haddock to reimplement the calculation of exported names from modules. Instead when renaming export lists ghc annotates each IE with its exported names. Haddocks current export logic has caused lots of trouble in the past (on the Github issue tracker): - haskell/haddock#121 - haskell/haddock#174 - haskell/haddock#225 - haskell/haddock#344 - haskell/haddock#584 - haskell/haddock#591 - haskell/haddock#597 Reviewers: austin, bgamari, ezyang Reviewed By: bgamari, ezyang Subscribers: rwbarton, thomie Differential Revision: https://phabricator.haskell.org/D3864
bgamari
pushed a commit
to bgamari/ghc
that referenced
this issue
Sep 5, 2017
This is another take on https://phabricator.haskell.org/D3844. This patch removes then need for haddock to reimplement the calculation of exported names from modules. Instead when renaming export lists ghc annotates each IE with its exported names. Haddocks current export logic has caused lots of trouble in the past (on the Github issue tracker): - haskell/haddock#121 - haskell/haddock#174 - haskell/haddock#225 - haskell/haddock#344 - haskell/haddock#584 - haskell/haddock#591 - haskell/haddock#597 Reviewers: austin, bgamari, ezyang Reviewed By: bgamari, ezyang Subscribers: rwbarton, thomie Differential Revision: https://phabricator.haskell.org/D3864
bgamari
pushed a commit
to bgamari/ghc
that referenced
this issue
Sep 5, 2017
This is another take on https://phabricator.haskell.org/D3844. This patch removes then need for haddock to reimplement the calculation of exported names from modules. Instead when renaming export lists ghc annotates each IE with its exported names. Haddocks current export logic has caused lots of trouble in the past (on the Github issue tracker): - haskell/haddock#121 - haskell/haddock#174 - haskell/haddock#225 - haskell/haddock#344 - haskell/haddock#584 - haskell/haddock#591 - haskell/haddock#597 Reviewers: austin, bgamari, ezyang Reviewed By: bgamari, ezyang Subscribers: rwbarton, thomie Differential Revision: https://phabricator.haskell.org/D3864
ghc-mirror
pushed a commit
to ghc/ghc
that referenced
this issue
Sep 5, 2017
This is another take on https://phabricator.haskell.org/D3844. This patch removes then need for haddock to reimplement the calculation of exported names from modules. Instead when renaming export lists ghc annotates each IE with its exported names. Haddocks current export logic has caused lots of trouble in the past (on the Github issue tracker): - haskell/haddock#121 - haskell/haddock#174 - haskell/haddock#225 - haskell/haddock#344 - haskell/haddock#584 - haskell/haddock#591 - haskell/haddock#597 Updates haddock submodule. Reviewers: austin, bgamari, ezyang Reviewed By: bgamari, ezyang Subscribers: rwbarton, thomie Differential Revision: https://phabricator.haskell.org/D3864
We're also affected by this. I thought it was a problem in the way we were using Haddock, so I asked a question at SO. |
should be resolved by #688 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I've just been trying to re-export modules with Haddock, but I ran into several annoying issues:
A
andB
do not appear in the documentation forFoo
.A
andB
does appear in docs forFoo
:a
would appear in the docs forFoo
, even thougha
is not exported fromFoo
.(All of this assumes that modules
A
andB
are hidden in the cabal file, so that their contents should be dumped intoFoo
in an ideal world.)It doesn't seem that (1) is addressed in the docs. In particular, the modules are re-exported "wholly and without hiding qualifiers", and the docs mention nothing about renamed modules.
Point (2) is precisely what I expect/want to happen, so nothing to change there.
Point (3) may be addressed in the footnote [2] in the docs (can't quite tell), but this feature is pretty useless with the current behavior. The only option is for me to explicitly list what items I want to export, which is error-prone and difficult to maintain.
The text was updated successfully, but these errors were encountered: