azurerm_firewall: support snat private ip ranges

[magodo]

Support SNAT private ip ranges in azurerm_firewall.

Test Result

💤 via 🦉 v1.14.4 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS="-run='TestAccAzureRMFirewall_basic'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run='TestAccAzureRMFirewall_basic' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMFirewall_basic
=== PAUSE TestAccAzureRMFirewall_basic
=== CONT  TestAccAzureRMFirewall_basic
--- PASS: TestAccAzureRMFirewall_basic (1044.62s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       1044.638s

(Fix #7504)

[tombuildsstuff]

hey @magodo

Thanks for this PR :)

Taking a look through whilst this works it appears these fields need to be added to the Swagger?

Thanks!

[tombuildsstuff]

is there a reason these fields aren't exposed in the Swagger? historically the Networking API's have introduced breaking schema changes - so this is less likely if these are typed, since they'll be caught via ARM review?

[magodo]

@tombuildsstuff Seems ARM review will not check the changes on those mappings, as reviewer might not have knowledge on whether that is a regular map accepting arbitrary kv or a map playing role as special config using certain keys (as this one)

[tombuildsstuff]

@magodo in this instance we've had similar issues with DataBricks in the past and ended up having to send Swagger PR's to fix this (e.g. Azure/azure-rest-api-specs#7872) - so that'd be my next suggestion here

[magodo]

@tombuildsstuff Thank you for the example/suggestion to submit a PR to the Swagger. Whilst currently there is no document enumerating all the available KVs. Hence I'll submit an issue (Azure/azure-rest-api-specs#10015) instead.

[katbyte]

as this is blocked on swagger i'm going to close it @magodo, we can revive the branch once they've updated it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!