Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure_firewall: Define a dedicated property for SNAT private ranges #10015

Open
magodo opened this issue Jul 2, 2020 · 5 comments
Open

azure_firewall: Define a dedicated property for SNAT private ranges #10015

magodo opened this issue Jul 2, 2020 · 5 comments
Assignees
@yairt1974
Labels
Network - Firewall Azure Firewall question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@magodo
Copy link
Contributor

magodo commented Jul 2, 2020 •
edited
Loading

Currently, when users want to specify SNA private ranges, one will set the special key Network.SNAT.PrivateRanges in additionalProperties, with the value of ip ranges.

Is it possible to consolidate this into a dedicated property of its own, otherwise it is not that reliable to create toolings based on this special key, as it is possible to have breaking changes (e.g. renaming the key or change the format of the value)?

Even more, is there any document I can refer to which enumerates all the available KVs for the additionalProperties, so that I might come up with a PR to make additionalProperties a predefined model, rather than a flexible map?
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 2, 2020
@magodo magodo mentioned this issue Jul 2, 2020
Closed
@ChenTanyi ChenTanyi added Network Service Attention Workflow: This issue is responsible by Azure service team. labels Jul 2, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 2, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aznetsuppgithub.

@timMSFT timMSFT added Network - Front Door Service: Azure Front Door and removed Network labels Jul 2, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aznetsuppgithub.

@magodo
Copy link
Contributor Author

magodo commented Dec 16, 2020

@timMSFT @fengzhou-msft Any update? This currently blocks hashicorp/terraform-provider-azurerm#7535 from being merged, which resolves issue hashicorp/terraform-provider-azurerm#7504.

@timMSFT timMSFT added Network - Firewall Azure Firewall and removed Network - Front Door Service: Azure Front Door labels Dec 16, 2020
@ghost
Copy link

ghost commented Dec 16, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @fwsuppgithub.

Issue Details

Currently, when users want to specify SNA private ranges, one will set the special key Network.SNAT.PrivateRanges in additionalProperties, with the value of ip ranges.

Is it possible to consolidate this into a dedicated property of its own, otherwise it is not that reliable to create toolings based on this special key, as it is possible to have breaking changes (e.g. renaming the key or change the format of the value)?

Even more, is there any document I can refer to which enumerates all the available KVs for the additionalProperties, so that I might come up with a PR to make additionalProperties a predefined model, rather than a flexible map?

Author: magodo
Assignees: -
Labels:

Network - Firewall, Service Attention, question
Milestone: -

@magodo
Copy link
Contributor Author

magodo commented Mar 31, 2021

Png @timMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yairt1974 yairt1974

Labels
Network - Firewall Azure Firewall question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@magodo @yairt1974 @ChenTanyi @timMSFT @fengzhou-msft