databricks: switching `parameters` to be a proper struct #7872

mbfrahry · 2019-12-02T22:57:32Z

This is a continuation of #6917

As a part of the provisioning process, Databricks Clusters allow users to override certain values via a parameters block. Since there appears to be a fixed list of these:

customPrivateSubnetName, customPublicSubnetName, customVirtualNetworkId, enableNoPublicIp, relayNamespaceName, storageAccountName, storageAccountSkuName, vnetAddressPrefix, resourceTags, amlWorkspaceId.

from a usability perspective this would match other SDK's if these values were exposed as a native struct/class depending on the language, rather than being a generic dictionary; as such this PR changes parameters to a struct rather than a dictionary.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-12-02T22:59:30Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#9055

AutorestCI · 2019-12-02T23:02:36Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6465

weidongxu-microsoft · 2019-12-03T02:06:09Z

@mbfrahry

Please add code owner to reviewer. Also please try to pass CI as well. If you think any validation is not your fault please raise it.

KrisBash

I'm assuming that this is not breaking as the newly defined properties match the complete list of properties supported by the service previously? With that in mind, signing off. If this is breaking ,please expose in a new API version

AutorestCI · 2019-12-08T17:23:46Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

…aceCreateWithParameters.json

mbfrahry · 2019-12-08T18:02:20Z

@weidongxu-microsoft @KrisBash thanks for reviewing - the tests pass now 👍

weidongxu-microsoft · 2019-12-09T02:42:41Z

/azp run

azure-pipelines · 2019-12-09T02:43:02Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2019-12-09T02:44:46Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-09T02:44:51Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 592d22b with merge commit 5f5dcd1. SDK Automation 13.0.17
️✔️databricks/mgmt/2018-04-01 [Logs] [Release SDK Changes]
- databricks.mgmt.2018-04-01.zip

openapi-sdkautomation · 2019-12-09T02:44:54Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 592d22b with merge commit 5f5dcd1. SDK Automation 13.0.17

️✔️@azure/arm-databricks [Logs] [Release SDK Changes]

azure-arm-databricks-1.1.0.tgz

[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/databricksClient.js → ./dist/arm-databricks.js...
[npmPack] created ./dist/arm-databricks.js in 218ms

openapi-sdkautomation · 2019-12-09T02:44:56Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-09T02:44:58Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 592d22b with merge commit 5f5dcd1. SDK Automation 13.0.17

️✔️azure-mgmt-databricks [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

* databricks: switching `parameters` to be a proper struct * removing the unused required field * linting * DataBricks: matching the Swagger to the API request/response * Refactor nexamples/WorkspaceCreateParameters.json - > examples/WorkspaceCreateWithParameters.json * prettier * Update 201 body * Update resourceTags * DataBricks: fixing the parameter types

azuresdkci assigned weidongxu-microsoft Dec 2, 2019

azuresdkci requested a review from weidongxu-microsoft December 2, 2019 22:58

AutorestCI mentioned this pull request Dec 2, 2019

[AutoPR databricks/resource-manager] databricks: switching parameters to be a proper struct Azure/azure-sdk-for-python#8926

Merged

AutorestCI mentioned this pull request Dec 2, 2019

[AutoPR databricks/resource-manager] databricks: switching parameters to be a proper struct Azure/azure-sdk-for-go#6465

Closed

weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2019

KrisBash approved these changes Dec 3, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2019

weidongxu-microsoft approved these changes Dec 5, 2019

View reviewed changes

tombuildsstuff and others added 8 commits December 8, 2019 09:31

databricks: switching parameters to be a proper struct

2408b9b

removing the unused required field

f39db5c

linting

79d5956

DataBricks: matching the Swagger to the API request/response

f5da3d6

Refactor nexamples/WorkspaceCreateParameters.json - > examples/Worksp…

9f75257

…aceCreateWithParameters.json

prettier

2db2f2d

Update 201 body

1347d0d

Update resourceTags

4d8cd34

mbfrahry force-pushed the databricks-parameters-struct branch 4 times, most recently from 4e98936 to 97a68f3 Compare December 8, 2019 17:49

DataBricks: fixing the parameter types

592d22b

mbfrahry force-pushed the databricks-parameters-struct branch from 97a68f3 to 592d22b Compare December 8, 2019 17:53

weidongxu-microsoft merged commit 5f5dcd1 into Azure:master Dec 9, 2019

tombuildsstuff mentioned this pull request Jul 1, 2020

azurerm_firewall: support snat private ip ranges hashicorp/terraform-provider-azurerm#7535

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

databricks: switching `parameters` to be a proper struct #7872

databricks: switching `parameters` to be a proper struct #7872

mbfrahry commented Dec 2, 2019

AutorestCI commented Dec 2, 2019 •

edited

Loading

AutorestCI commented Dec 2, 2019 •

edited

Loading

weidongxu-microsoft commented Dec 3, 2019

KrisBash left a comment

AutorestCI commented Dec 8, 2019

mbfrahry commented Dec 8, 2019

weidongxu-microsoft commented Dec 9, 2019

azure-pipelines bot commented Dec 9, 2019

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

databricks: switching parameters to be a proper struct #7872

databricks: switching parameters to be a proper struct #7872

Conversation

mbfrahry commented Dec 2, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Dec 2, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Dec 2, 2019 • edited Loading

Automation for azure-sdk-for-go

weidongxu-microsoft commented Dec 3, 2019

KrisBash left a comment

Choose a reason for hiding this comment

AutorestCI commented Dec 8, 2019

mbfrahry commented Dec 8, 2019

weidongxu-microsoft commented Dec 9, 2019

azure-pipelines bot commented Dec 9, 2019

openapi-sdkautomation bot commented Dec 9, 2019 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Dec 9, 2019 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Dec 9, 2019 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Dec 9, 2019 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Dec 9, 2019 • edited Loading

azure-sdk-for-python - Release

databricks: switching `parameters` to be a proper struct #7872

databricks: switching `parameters` to be a proper struct #7872

AutorestCI commented Dec 2, 2019 •

edited

Loading

AutorestCI commented Dec 2, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 9, 2019 •

edited

Loading