-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication: making the client registration consistent #1845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Given this affects every resource in the provider - we're going to handle the tests for this via the nightly run. A cursory test of a Resource Group test passes:
|
* timcurless/timcurless: Fixing issues with aadProfile server_app_secret always causing a new cluster Adding documentation updates Updating to include hashicorp#1845 Authentication: registering all clients consistently (hashicorp#1845) Updating to include hashicorp#1843 r/Logic App: ensuring parameters are strings prior to setting (hashicorp#1843) Updating to include hashicorp#1821 linux_profile should be optional to align with API spec (hashicorp#1821) Updating to include hashicorp#1816 Storage: Import Support (hashicorp#1816) Updating to include hashicorp#1835 Allow azurerm_function_app to use upper case names in consumption plan (hashicorp#1835) formatting
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This is a requirement for #1746 and the branch
proxy-support
- and is being made out-of-band to get this in ASAP to avoid extra conflicts (since this is a commonly touched file)